Date: Wed, 24 Jul 2013 16:45:14 -0700 (PDT)
Message-Id: <20130724.164514.393667021861625699.davem@davemloft.net>
To: pebolle@tiscali.nl
Cc: andi@etezian.org, ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net,
        v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: trans_rdma: remove unused function
From: David Miller <davem@davemloft.net>
In-Reply-To: <1374707387.29835.23.camel@x61.thuisdomein>
References: <1374497956-32104-1-git-send-email-andi@etezian.org>
	<20130724.154646.2283898956674234778.davem@davemloft.net>
	<1374707387.29835.23.camel@x61.thuisdomein>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-7
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1300
Lines: 31

From: Paul Bolle <pebolle@tiscali.nl>
Date: Thu, 25 Jul 2013 01:09:47 +0200

> On Wed, 2013-07-24 at 15:46 -0700, David Miller wrote:
>> From: Andi Shyti <andi@etezian.org>
>> > This patch gets rid of the following warning:
>> > 
>> > net/9p/trans_rdma.c:594:12: warning: ?rdma_cancelled? defined but not used [-Wunused-function]
>> >  static int rdma_cancelled(struct p9_client *client, struct p9_req_t *req)
>> > 
>> > The rdma_cancelled function is not called anywhere in the kernel
>> > 
>> > Signed-off-by: Andi Shyti <andi@etezian.org>
>> 
>> Applied to net-next, thanks.
> 
> After this patch one might as well revert the rest of commit
> 80b45261a0b2 ("9P: Add cancelled() to the transport functions.") too. It
> seems the entire cancelled callback stuff is now pointless.
> 
> As I already asked in https://lkml.org/lkml/2013/7/15/87 : did that
> commit "forget to actually hook up rdma_cancelled() into
> p9_rdma_trans()?". It does look so to me.

If nobody responds to this in the next day or so, feel free to send me
a patch which rips it all out.

No response means they don't care, and neither, therefore, should we.

Thanks.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?