Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754029Ab3GYChL (ORCPT ); Wed, 24 Jul 2013 22:37:11 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:45863 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752475Ab3GYChH (ORCPT ); Wed, 24 Jul 2013 22:37:07 -0400 MIME-Version: 1.0 In-Reply-To: <20130724193519.GA16434@merkur.ravnborg.org> References: <1374654692-13237-1-git-send-email-mail-agent-noreply@emc.com> <1374654692-13237-2-git-send-email-mail-agent-noreply@emc.com> <1374654692-13237-3-git-send-email-mail-agent-noreply@emc.com> <1374654692-13237-4-git-send-email-mail-agent-noreply@emc.com> <1374654692-13237-5-git-send-email-mail-agent-noreply@emc.com> <1374654692-13237-6-git-send-email-mail-agent-noreply@emc.com> <1374654692-13237-7-git-send-email-mail-agent-noreply@emc.com> <20130724193519.GA16434@merkur.ravnborg.org> From: Peng Tao Date: Thu, 25 Jul 2013 10:36:45 +0800 Message-ID: Subject: Re: [PATCH 6/8] staging/lustre: fix Kconfig bool defaults To: Sam Ravnborg Cc: mail-agent-noreply@emc.com, Greg Kroah-Hartman , Linux Kernel Mailing List , Andreas Dilger Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1945 Lines: 52 On Thu, Jul 25, 2013 at 3:35 AM, Sam Ravnborg wrote: > On Wed, Jul 24, 2013 at 04:31:30PM +0800, mail-agent-noreply@emc.com wrote: >> From: Peng Tao >> >> Should be y instead of true. >> >> Reported-by: Paul Bolle >> Cc: Andreas Dilger >> Signed-off-by: Peng Tao >> --- >> drivers/staging/lustre/lustre/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig >> index 9ae7fa8..e3b3c74 100644 >> --- a/drivers/staging/lustre/lustre/Kconfig >> +++ b/drivers/staging/lustre/lustre/Kconfig >> @@ -52,4 +52,4 @@ config LUSTRE_DEBUG_EXPENSIVE_CHECK >> config LUSTRE_TRANSLATE_ERRNOS >> bool >> depends on LUSTRE_FS && !X86 >> - default true >> + default y > > This was the file that contained some buggy "default false" IIRC. > Please delete these. > The default false lines were already deleted by Paul Bolle. Please see commit 68a8029799ad368ee82a5cf509a2b5b802837ce9 in Greg's staging-next branch. commit 68a8029799ad368ee82a5cf509a2b5b802837ce9 Author: Paul Bolle Date: Sat Jul 13 20:46:39 2013 +0200 staging/lustre/libcfs: drop bogus Kconfig default Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added "default false" to this Kconfig file. It was obviously meant to use "default n" here. But we might as well drop this line, as a Kconfig bool defaults to 'n' anyway. Signed-off-by: Paul Bolle Signed-off-by: Greg Kroah-Hartman Thanks, Tao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/