Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754996Ab3GYICo (ORCPT ); Thu, 25 Jul 2013 04:02:44 -0400 Received: from mga02.intel.com ([134.134.136.20]:16845 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754862Ab3GYIC0 (ORCPT ); Thu, 25 Jul 2013 04:02:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,742,1367996400"; d="scan'208";a="351296248" Date: Thu, 25 Jul 2013 12:53:51 +0530 From: Vinod Koul To: Joel Fernandes Cc: Lars-Peter Clausen , Dan Williams , Tony Lindgren , "Nori, Sekhar" , Arnd Bergmann , "Shilimkar, Santosh" , "Nayak, Rajendra" , "Vutla, Lokesh" , "Krishnamoorthy, Balaji T" , Matt Porter , Rob Herring , Jason Kridner , Koen Kooi , Linux OMAP List , Linux ARM Kernel List , Linux Kernel Mailing List , Linux MMC List Subject: Re: [PATCH] dma: edma: add device_slave_caps() support Message-ID: <20130725072351.GJ18642@intel.com> References: <1374597804-3961-1-git-send-email-joelf@ti.com> <51EF8A52.90902@metafoo.de> <51EF8C2B.2030409@ti.com> <51EF8F4E.8080806@metafoo.de> <51EF92F2.3030405@metafoo.de> <51F0231C.7000401@ti.com> <20130724183329.GH18642@intel.com> <51F02CBA.5060704@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51F02CBA.5060704@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1471 Lines: 27 On Wed, Jul 24, 2013 at 02:36:26PM -0500, Joel Fernandes wrote: > > Also another point worth considering is the approach Russell suggested, I havent > > gotten a chance to dig deeper but if I understood it correctly then programming > > the device_dma_parameters should be the right thing to do. Again I need to look > > deeper and esp wrt edma > > OK. I have some patches sitting in my tree too that I'm working on. With > that I don't need to know about maximum number of allowed segments and > can send along any number of segment. I will rework them and post them. > fwiw, I will also implement caps API incase like Lars did populating the > other fields though these will not be unused. > > For segment size, at this time I don't know any driver that uses it > other than davinci-pcm. For this reason the calculations can be done as > Lars suggested (for minimum of maximum). Do you know in advance if > you're going to amend to drop segment size if we go with what Russell > suggested, or are you going to leave the seg-size in the caps API anyway. I am just back and havent really done my work on this. Let me check and as I said if my understanding is right I would be inclined to remove these fields... ~Vinod -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/