Date: Thu, 25 Jul 2013 10:27:41 +0200
From: Andi Shyti <andi@etezian.org>
To: Dominique Martinet <dominique.martinet@cea.fr>
Cc: David Miller <davem@davemloft.net>, pebolle@tiscali.nl, lucho@ionkov.net,
        ericvh@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        andi@etezian.org, v9fs-developer@lists.sourceforge.net,
        rminnich@sandia.gov
Subject: Re: [V9fs-developer] [PATCH] net: trans_rdma: remove unused function
Message-ID: <20130725082741.GB4295@jack.whiskey>
References: <1374497956-32104-1-git-send-email-andi@etezian.org>
 <20130724.154646.2283898956674234778.davem@davemloft.net>
 <1374707387.29835.23.camel@x61.thuisdomein>
 <20130724.164514.393667021861625699.davem@davemloft.net>
 <20130725061411.GA8579@nautica>
 <20130725064802.GA12569@nautica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130725064802.GA12569@nautica>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1246
Lines: 34

Hi,

> To be more precise, there's a single call to c->trans_mode->cancelled in
> net/9p/client.c, in p9_client_flush, which is called on subfunction returning
> -ERESTARTSYS... which never happens as far as I could see.
> 
> This will be useful once/if we start working on client recovery, though
> - so the function in itself definitely does interest me, and I guess
> that thinking about I would have preferred to have the hook added rather
> than the function removed.
> But there definitely is no hurry to add this cancelled function till
> then.

I would prefer to NACK my patch, it messes up things more than
fixes.

If we really want to get rid of this function we should
completely revert this patch:

80b45261a0b263536b043c5ccfc4ba4fc27c2acc

otherwise, spread in the code, there will be empty references to
the 'cancelled' function (struct p9_trans_module in transport.h
and the one you mentioned).

I would rather prefer Paul's approach to mine, let's just get rid
of the warning :)

Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/