Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755441Ab3GYJIh (ORCPT ); Thu, 25 Jul 2013 05:08:37 -0400 Received: from mail-bk0-f53.google.com ([209.85.214.53]:53432 "EHLO mail-bk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755225Ab3GYJIH (ORCPT ); Thu, 25 Jul 2013 05:08:07 -0400 Message-ID: <51F0EAF3.1060606@gmail.com> Date: Thu, 25 Jul 2013 11:08:03 +0200 From: Daniel Mack User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Aaro Koskinen CC: Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: v3.11-rc1 USB regressions References: <20130715225647.GE3296@blackmetal.musicnaut.iki.fi> <51E4E922.2040707@gmail.com> <20130716175710.GA14385@blackmetal.musicnaut.iki.fi> <20130724185119.GB26943@blackmetal.musicnaut.iki.fi> <51F0253C.7090205@gmail.com> <20130725003029.GD26943@blackmetal.musicnaut.iki.fi> In-Reply-To: <20130725003029.GD26943@blackmetal.musicnaut.iki.fi> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1530 Lines: 37 On 25.07.2013 02:30, Aaro Koskinen wrote: > On Wed, Jul 24, 2013 at 09:04:28PM +0200, Daniel Mack wrote: >> On 24.07.2013 20:51, Aaro Koskinen wrote: >>>> When I revert fe4cb0912f8e737f8e4b8b38b9e692f8062f5423 and >>>> 8b125df5b24cfb0ec7fa1971e343cc0badc1827d, it works like before (3.10): >>> >>> I'm now running -rc2 with above fixes and reverts (the only way to get >>> USB working). I'm seeing an additional issue, the following crash happens >>> always on N900 when doing "poweroff": >> >> Yes, with the mentioned patches reverted, musb_to_hcd() will return a >> faulty pointer. You can't easily revert them unfortunately. >> >> Your platform needs a real fix, I just have trouble understanding why a >> removed usb_add_hcd() would make the gadget code fail. >> >> Sorry for the trouble, but I don't currently have a board with musb in >> gadget mode to reproduce this issue. > > If you have any ideas what to look for, I can maybe try to debug this > issue. Please try changing the .mode field of musb_board_data to MUSB_OTG in your board file (arch/arm/mach-omap2/board-rx51.c). That should bring back the call to usb_add_hcd(), provided that you have USB_MUSB_DUAL_ROLE=y. I still don't see a reason why this is should be necessary for peripheral-only use though. Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/