Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755530Ab3GYJaq (ORCPT ); Thu, 25 Jul 2013 05:30:46 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:56938 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755071Ab3GYJak (ORCPT ); Thu, 25 Jul 2013 05:30:40 -0400 Message-ID: <51F0F036.60808@atmel.com> Date: Thu, 25 Jul 2013 10:30:30 +0100 From: Rupesh Gujare User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: CC: , , , Subject: Re: [PATCH] staging: ozwpan: Fix coding style. References: <1374674806-7790-1-git-send-email-rupesh.gujare@atmel.com> In-Reply-To: <1374674806-7790-1-git-send-email-rupesh.gujare@atmel.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2222 Lines: 72 On 24/07/13 15:06, Rupesh Gujare wrote: > This patch fixes coding style issues reported by Dan here:- > http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2012-June/027767.html > > Signed-off-by: Rupesh Gujare > --- > drivers/staging/ozwpan/ozcdev.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c > index 3e29760..73b582c 100644 > --- a/drivers/staging/ozwpan/ozcdev.c > +++ b/drivers/staging/ozwpan/ozcdev.c > @@ -333,10 +333,11 @@ int oz_cdev_register(void) > { > int err; > struct device *dev; > + > memset(&g_cdev, 0, sizeof(g_cdev)); > err = alloc_chrdev_region(&g_cdev.devnum, 0, 1, "ozwpan"); > if (err < 0) > - goto out3; > + return err; > oz_dbg(ON, "Alloc dev number %d:%d\n", > MAJOR(g_cdev.devnum), MINOR(g_cdev.devnum)); > cdev_init(&g_cdev.cdev, &oz_fops); > @@ -347,26 +348,26 @@ int oz_cdev_register(void) > err = cdev_add(&g_cdev.cdev, g_cdev.devnum, 1); > if (err < 0) { > oz_dbg(ON, "Failed to add cdev\n"); > - goto out2; > + goto unregister; > } > g_oz_class = class_create(THIS_MODULE, "ozmo_wpan"); > if (IS_ERR(g_oz_class)) { > oz_dbg(ON, "Failed to register ozmo_wpan class\n"); > err = PTR_ERR(g_oz_class); > - goto out1; > + goto delete; > } > dev = device_create(g_oz_class, NULL, g_cdev.devnum, NULL, "ozwpan"); > if (IS_ERR(dev)) { > oz_dbg(ON, "Failed to create sysfs entry for cdev\n"); > err = PTR_ERR(dev); > - goto out1; > + goto delete; > } > return 0; > -out1: > + > +delete: > cdev_del(&g_cdev.cdev); > -out2: > +unregister: > unregister_chrdev_region(g_cdev.devnum, 1); > -out3: > return err; > } > /*------------------------------------------------------------------------------ Greg, Did you missed this patch ? Or did I made another mistake. :( ? -- Regards, Rupesh Gujare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/