Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755444Ab3GYKLf (ORCPT ); Thu, 25 Jul 2013 06:11:35 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:59497 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754779Ab3GYKLd (ORCPT ); Thu, 25 Jul 2013 06:11:33 -0400 MIME-Version: 1.0 In-Reply-To: <51F0F88D.8060903@cn.fujitsu.com> References: <51F0F88D.8060903@cn.fujitsu.com> Date: Thu, 25 Jul 2013 12:11:32 +0200 X-Google-Sender-Auth: AApd2wEjCkaTf2basAWF4VMeyEw Message-ID: Subject: Re: [PATCH V2] driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy() From: Geert Uytterhoeven To: Gu Zheng Cc: Jean-Christophe PLAGNIOL-VILLARD , Tomi Valkeinen , Linux Fbdev development list , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1137 Lines: 31 On Thu, Jul 25, 2013 at 12:06 PM, Gu Zheng wrote: > Commit e21d2170f36602ae2708 ("video: remove unnecessary > platform_set_drvdata()") removed the unnecessary platform_set_drvdata(), > but left the variable "dev" unused, delete it. > > v2: > Following Geert's suggestion to make change log easier reading. > > Signed-off-by: Gu Zheng > --- Please send a v3, which has the version info under the above "---", instead of making it a part of the patch description to be committed. Thanks again! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/