Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755613Ab3GYMQf (ORCPT ); Thu, 25 Jul 2013 08:16:35 -0400 Received: from mail-oa0-f42.google.com ([209.85.219.42]:38470 "EHLO mail-oa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751680Ab3GYMQc (ORCPT ); Thu, 25 Jul 2013 08:16:32 -0400 MIME-Version: 1.0 In-Reply-To: References: <1374646199-9398-1-git-send-email-pshah.mumbai@gmail.com> <51F07489.7010404@gmail.com> Date: Thu, 25 Jul 2013 15:16:32 +0300 Message-ID: Subject: Re: [PATCH] Change request_irq() to use struct net_device *dev->name From: Andy Shevchenko To: Prashant Shah Cc: Ryan Mallon , netdev , "linux-kernel@vger.kernel.org" , mwhitehe@redhat.com, kernel-mentors@selenic.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1201 Lines: 31 On Thu, Jul 25, 2013 at 8:38 AM, Prashant Shah wrote: > On Thu, Jul 25, 2013 at 10:49 AM, Prashant Shah wrote: >>> You should also remove the definition of DRV_NAME, since it is no longer >>> used. The changelog should probably mention that this will change the >>> interrupt name (which appears in /proc/interrupts for example) from "wd" >>> to "eth%d". > > I was going through the code. The apne driver apne.c in the same > folder is using DRV_NAME in request_region() > >> if (!request_region(IOBASE, 0x20, DRV_NAME)) { > > I can change the wd.c request_region() code to use DRV_NAME. Currently > it is using a string constant. > >> r = request_region(base_addr, WD_IO_EXTENT, "wd-probe"); > > This will make it more consistent. Please suggest which change is more > preferable. If you convert each driver to use devres API, you may avoid a lot of useless work. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/