Message-ID: <51F12668.8000400@suse.cz>
Date: Thu, 25 Jul 2013 15:21:44 +0200
From: Michal Marek <mmarek@suse.cz>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6
MIME-Version: 1.0
To: Frank Haverkamp <haver@vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org,
        cody@linux.vnet.ibm.com, schwidefsky@de.ibm.com, utz.bacher@de.ibm.com,
        jsvogt@de.ibm.com, MIJUNG@de.ibm.com, cascardo@linux.vnet.ibm.com,
        michael@ibmra.de
Subject: Re: [PATCH] Generic WorkQueue Engine (GenWQE) device driver
References: <1374740897-20304-1-git-send-email-haver@vnet.ibm.com> <1374740897-20304-2-git-send-email-haver@vnet.ibm.com>
In-Reply-To: <1374740897-20304-2-git-send-email-haver@vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 991
Lines: 24

On 25.7.2013 10:28, Frank Haverkamp wrote:
> +	dev_info(&pci_dev->dev, "GenWQE driver version: %s (build %s) %s%u\n",
> +		 DRV_VERS_STRING, __DATE__, GENWQE_DEVNAME, cd->card_idx);
[...]
> +	len += scnprintf(&buf[len], PAGE_SIZE - len,
> +			 "GenWQE driver version: %s (build %s)\n"
> +			 "    Device Name/Type: %s %s CardIdx: %d\n"
> +			 "    SLU/APP Config  : 0x%016llx/0x%016llx\n"
> +			 "    Build Date/Type : %u/%x/%u %s\n"
> +			 "    Base Clock      : %u MHz\n"
> +			 "    Arch/SVN Release: %u/%llx\n"
> +			 "    Bitstream       : %llx\n",
> +			 DRV_VERS_STRING, __DATE__, dev_name(&pci_dev->dev),

Please remove the __DATE__ macros, so that the generated object code
does not literally change with the phase of the moon.

Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/