Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757936Ab3GYTQd (ORCPT ); Thu, 25 Jul 2013 15:16:33 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:32957 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756734Ab3GYTQa (ORCPT ); Thu, 25 Jul 2013 15:16:30 -0400 Date: Thu, 25 Jul 2013 20:16:04 +0100 From: Mark Brown To: Jean-Francois Moine Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Russell King , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Message-ID: <20130725191604.GQ9858@sirena.org.uk> References: <20130725111428.419ee278@armhf> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uXqDGoDRqNOsF677" Content-Disposition: inline In-Reply-To: <20130725111428.419ee278@armhf> X-Cookie: You will be awarded some great honor. User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 94.175.92.69 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/4] ASoc: kirkwood: merge kirkwood-i2c and kirkwood-dma X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on cassiel.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1977 Lines: 49 --uXqDGoDRqNOsF677 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 25, 2013 at 11:14:28AM +0200, Jean-Francois Moine wrote: > To avoid the declaration of a 'kirkwood-pcm-audio' device in the DT, > this patch merges the kirkwood-i2c and kirkwood-dma drivers into one > module. This seems mostly fine, though it may be best to keep kirkwood-dma as a separate module for the benefit of the S/PDIF support when it gets added - I had a look at the implementation Russell has and it looks like it can be added as a separate interface. > - .platform_name = "kirkwood-pcm-audio", > + .platform_name = "kirkwood-i2s", Should the name be done as dev_name() for the interface (I don't know if there is ever more than one)? --uXqDGoDRqNOsF677 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJR8XlxAAoJELSic+t+oim96KkQAI1ZCIRwUCURAg2+SoDxHgqq rLrcVNf2D7a9yMw1z3muobdHvvIkXaFnQBaszyOP/eHjEfoZap7ilyCU+SB0Ho6o 5BzPG8HKGrBiiDovAxmVvqwJgLpi34mMhKd01Ay+z+Y2GvQdx7hiUpcGL05F8yKg Yi9JxORKtAWp/NGDGzlZ3EKGE/vHudX28WeNYwrecC5sJOssW2Qov/mYgBvBWdyH z8Geb9778/FpVaDmOh9e5YdnSy6fEL3fOXn0DfptKySEwKvkfC5tkOoKb8ikh1ad SoFW/xpjMNHb5HaLuV6ta4cUQ8QK3JlZhlZOKcOSKcGPhrAOAnEb4FVa0KbNME2j 5xwXFe6CAVkqy+FPxD6b5YE2pmDrw7LJwYXXf89rZJ3EiF4Ldapfk1NVa5tKRN4m 2D3wfX7eVWGJNJC/N8sIpQRrIv0uMqfH4spuu0IDgxiCNBrvhrxGNZbwCswCatf9 i2VFe6bbKh4eT8iep7gWL3QHk6Z0JonV54duulaYLf5ZX2eSjh+JXJeGyydkacII ir3R1q+ERGBcXZvtHz9L8P4uxq1jYfg2s0N7g3c6qVO12hbiOBN2UScuVv8/rqxa 01KK7td9OxzDcLForwe09qU1p1eCmfKgLeTGCctof15LAMkQX7Gq1ZSQqbh+rNO6 +rDMcuBTCpdO/zsrqkFt =UvGR -----END PGP SIGNATURE----- --uXqDGoDRqNOsF677-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/