Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932152Ab3GYXRt (ORCPT ); Thu, 25 Jul 2013 19:17:49 -0400 Received: from mga01.intel.com ([192.55.52.88]:2828 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756602Ab3GYXRs (ORCPT ); Thu, 25 Jul 2013 19:17:48 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.89,746,1367996400"; d="scan'208";a="376248197" From: "Dilger, Andreas" To: Xiong Zhou , Peng Tao CC: Jiri Kosina , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman Subject: Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig Thread-Topic: [PATCH] staging/lustre: add BLOCK depends in Kconfig Thread-Index: AQHOiQWa6Ypo0E8Su0K9tUbRNoTVL5l2GQ6A Date: Thu, 25 Jul 2013 23:17:46 +0000 Message-ID: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.106.6] Content-Type: text/plain; charset="utf-8" Content-ID: <2DA4052B0AF936449A81B3BB3FA3F87B@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r6PNHtvH007852 Content-Length: 1560 Lines: 46 On 2013/07/25 1:06 AM, "Xiong Zhou" wrote: >From: Xiong Zhou > >Add BLOCK depends in Kconfig for LUSTRE to fix this: >drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2 >: >error: implicit declaration of function ʽunregister_blkdevʼ > >Signed-off-by: Xiong Zhou >--- > drivers/staging/lustre/lustre/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/staging/lustre/lustre/Kconfig >b/drivers/staging/lustre/lustre/Kconfig >index 9ae7fa8..0b45de0 100644 >--- a/drivers/staging/lustre/lustre/Kconfig >+++ b/drivers/staging/lustre/lustre/Kconfig >@@ -1,6 +1,6 @@ > config LUSTRE_FS > tristate "Lustre file system client support" >- depends on STAGING && INET && m >+ depends on STAGING && INET && BLOCK && m > select LNET > select CRYPTO > select CRYPTO_CRC32 The Lustre client does not need a block device - it is a network filesystem. The one piece of code that is relevant here relates to a Lustre-optimized "loop" device that bypasses the VFS, data copying, and DLM locking for use by swap and such. It would be better instead to make that code conditional and add a new CONFIG_LUSTRE_LLOOP or similar, and only make that part dependent on BLOCK. Cheers, Andreas -- Andreas Dilger Lustre Software Architect Intel High Performance Data Division ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?