Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 10 Oct 2002 13:18:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 10 Oct 2002 13:18:58 -0400 Received: from smtp.urbanet.ch ([195.202.193.135]:34469 "HELO smtp.urbanet.ch") by vger.kernel.org with SMTP id ; Thu, 10 Oct 2002 13:18:57 -0400 From: Sylvain Pasche MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <15781.47072.335973.295982@yahoo.fr> Date: Thu, 10 Oct 2002 19:24:48 +0200 To: linux-kernel@vger.kernel.org Subject: 2.5.41 isofs patch to avoid "bad: scheduling while atomic!" X-Mailer: VM 7.04 under 21.4 (patch 8) "Honest Recruiter" XEmacs Lucid Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1659 Lines: 48 Without the patch: bad: scheduling while atomic! Call Trace: [] schedule+0x3d/0x4d4 [] smp_apic_timer_interrupt+0x111/0x124 [] need_resched+0x1f/0x2a [] sysvipc_sem_read_proc+0x1b0/0x227 [] serial_in+0x45/0x4c [] serial8250_console_write+0x5d/0x1cc [] __call_console_drivers+0x3e/0x50 [] _call_console_drivers+0x53/0x58 [] call_console_drivers+0xb5/0xe0 [] release_console_sem+0xc3/0x164 [] printk+0x1a7/0x1f4 [] __might_sleep+0x4f/0x58 [] __alloc_pages+0x24/0x24c [] __get_free_pages+0x28/0x60 [] isofs_readdir+0x6f/0xf7 [isofs] [] vfs_readdir+0x75/0x88 [] filldir64+0x0/0x114 [] sys_getdents64+0x4f/0xb3 [] filldir64+0x0/0x114 [] sys_fcntl64+0x85/0x98 [] sys_fcntl64+0x91/0x98 [] syscall_call+0x7/0xb the simple fix: --- linux-2.5.41/fs/isofs/dir.c_old 2002-10-10 19:12:19.000000000 +0200 +++ linux-2.5.41/fs/isofs/dir.c 2002-10-10 19:13:26.000000000 +0200 @@ -256,7 +256,7 @@ lock_kernel(); - tmpname = (char *) __get_free_page(GFP_KERNEL); + tmpname = (char *) __get_free_page(GFP_KERNEL | GFP_ATOMIC); if (!tmpname) return -ENOMEM; tmpde = (struct iso_directory_record *) (tmpname+1024); Sylvain Pasche - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/