Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752787Ab3GZG2M (ORCPT ); Fri, 26 Jul 2013 02:28:12 -0400 Received: from smtp1-g21.free.fr ([212.27.42.1]:41150 "EHLO smtp1-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265Ab3GZG2K convert rfc822-to-8bit (ORCPT ); Fri, 26 Jul 2013 02:28:10 -0400 Date: Fri, 26 Jul 2013 08:28:18 +0200 From: Jean-Francois Moine To: Mark Brown Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Russell King , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/4] ASoc: kirkwood: simplify probe error Message-ID: <20130726082818.480d2a02@armhf> In-Reply-To: <20130725191059.GO9858@sirena.org.uk> References: <20130725111357.7c976963@armhf> <20130725191059.GO9858@sirena.org.uk> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.20; arm-unknown-linux-gnueabihf) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 839 Lines: 28 On Thu, 25 Jul 2013 20:10:59 +0100 Mark Brown wrote: > On Thu, Jul 25, 2013 at 11:13:57AM +0200, Jean-Francois Moine wrote: > > The function kirkwood_i2s_dev_remove() may be used when probe fails. > > This seems fine but doesn't apply against current code but otherwise > seems fine. My base is 3.11-rc2. > > + if (!IS_ERR(priv->extclk)) { > > + clk_disable_unprepare(priv->extclk); > > + clk_put(priv->extclk); > > + } > > Could use devm_clk_get() for extclk. I will do it. -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/