Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753407Ab3GZGyK (ORCPT ); Fri, 26 Jul 2013 02:54:10 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:51365 "EHLO mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752149Ab3GZGyG convert rfc822-to-8bit (ORCPT ); Fri, 26 Jul 2013 02:54:06 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Fri, 26 Jul 2013 14:54:04 +0800 Message-ID: Subject: Re: [PATCH] staging/lustre: add BLOCK depends in Kconfig From: Xiong Zhou To: "Dilger, Andreas" Cc: Peng Tao , Jiri Kosina , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1906 Lines: 56 2013/7/26 Dilger, Andreas : > On 2013/07/25 1:06 AM, "Xiong Zhou" wrote: > >>From: Xiong Zhou >> >>Add BLOCK depends in Kconfig for LUSTRE to fix this: >>drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2 >>: >>error: implicit declaration of function ʽunregister_blkdevʼ >> >>Signed-off-by: Xiong Zhou >>--- >> drivers/staging/lustre/lustre/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>diff --git a/drivers/staging/lustre/lustre/Kconfig >>b/drivers/staging/lustre/lustre/Kconfig >>index 9ae7fa8..0b45de0 100644 >>--- a/drivers/staging/lustre/lustre/Kconfig >>+++ b/drivers/staging/lustre/lustre/Kconfig >>@@ -1,6 +1,6 @@ >> config LUSTRE_FS >> tristate "Lustre file system client support" >>- depends on STAGING && INET && m >>+ depends on STAGING && INET && BLOCK && m >> select LNET >> select CRYPTO >> select CRYPTO_CRC32 > > The Lustre client does not need a block device - it is a network > filesystem. > The one piece of code that is relevant here relates to a Lustre-optimized > "loop" device that bypasses the VFS, data copying, and DLM locking for use > by swap and such. It would be better instead to make that code conditional > and add a new CONFIG_LUSTRE_LLOOP or similar, and only make that part > dependent > on BLOCK. > > Cheers, Andreas > -- > Andreas Dilger > This makes sence. I noticed that this patch has gone into Greg's tree, so a coming patch based on this patch is cool? > Lustre Software Architect > Intel High Performance Data Division > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/