Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757594Ab3GZH2H (ORCPT ); Fri, 26 Jul 2013 03:28:07 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:37968 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756762Ab3GZH2D (ORCPT ); Fri, 26 Jul 2013 03:28:03 -0400 MIME-Version: 1.0 In-Reply-To: <1374770011-22171-4-git-send-email-l.majewski@samsung.com> References: <1370502472-7249-1-git-send-email-l.majewski@samsung.com> <1374770011-22171-1-git-send-email-l.majewski@samsung.com> <1374770011-22171-4-git-send-email-l.majewski@samsung.com> Date: Fri, 26 Jul 2013 12:58:02 +0530 Message-ID: Subject: Re: [PATCH v6 3/8] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution From: Viresh Kumar To: Lukasz Majewski Cc: "Rafael J. Wysocki" , Zhang Rui , Eduardo Valentin , "cpufreq@vger.kernel.org" , Linux PM list , Jonghwa Lee , Lukasz Majewski , linux-kernel , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Kukjin Kim , Myungjoo Ham , durgadoss.r@intel.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1144 Lines: 34 On 25 July 2013 22:03, Lukasz Majewski wrote: > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c > static void __init acpi_cpufreq_boost_init(void) > { > + acpi_cpufreq_driver.boost_supported = false; Would be better if we do this in else of below if. > if (boot_cpu_has(X86_FEATURE_CPB) || boot_cpu_has(X86_FEATURE_IDA)) { > msrs = msrs_alloc(); > @@ -1021,12 +995,11 @@ static int __init acpi_cpufreq_init(void) > *iter = &cpb; > } > #endif > + acpi_cpufreq_boost_init(); We are calling it before registering cpufreq driver. Will this have any complications? > ret = cpufreq_register_driver(&acpi_cpufreq_driver); > if (ret) > free_acpi_perf_data(); > - else > - acpi_cpufreq_boost_init(); > > return ret; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/