Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757212Ab3GZHdM (ORCPT ); Fri, 26 Jul 2013 03:33:12 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:26698 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753454Ab3GZHdK (ORCPT ); Fri, 26 Jul 2013 03:33:10 -0400 Date: Fri, 26 Jul 2013 10:32:33 +0300 From: Dan Carpenter To: Wei Yongjun Cc: gregkh@linuxfoundation.org, wonkang@gctsemi.com, joe@perches.com, devel@driverdev.osuosl.org, yongjun_wei@trendmicro.com.cn, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] staging: gdm724x: use GFP_ATOMIC under spin lock Message-ID: <20130726073233.GD5585@mwanda> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 671 Lines: 20 On Fri, Jul 26, 2013 at 10:15:55AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > A spin lock is taken here so we should use GFP_ATOMIC. > Acked-by: Dan Carpenter But the locking here is really odd and pointless. usb_submit_urb() returns asynchronously before the data has been sent, so there is almost no point in locking around it. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/