Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756019Ab3GZTCy (ORCPT ); Fri, 26 Jul 2013 15:02:54 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:64564 "EHLO mail-we0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094Ab3GZTCx (ORCPT ); Fri, 26 Jul 2013 15:02:53 -0400 MIME-Version: 1.0 In-Reply-To: <20130726185609.GY9858@sirena.org.uk> References: <1374863133-6745-1-git-send-email-eu@felipetonello.com> <1374863133-6745-5-git-send-email-eu@felipetonello.com> <20130726185609.GY9858@sirena.org.uk> Date: Fri, 26 Jul 2013 12:02:51 -0700 Message-ID: Subject: Re: [PATCH 4/4] ALSA: oxygen: Updating jack implementation according new ALSA Jacks From: Felipe Tonello To: Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , David Henningsson , Wang Xingchao , Jaroslav Kysela Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 32 Hi Mark, On Fri, Jul 26, 2013 at 11:56 AM, Mark Brown wrote: > On Fri, Jul 26, 2013 at 11:25:33AM -0700, Felipe F. Tonello wrote: >> From: "Felipe F. Tonello" >> >> ALSA standard jacks already are implemented using ALSA KControl. >> So there is no need implement that itself or to use snd_jack >> for input events only. > > Similar changlog comment as on the ASoC patch and... Ok. > >> snd_jack_new(chip->card, "Headphone", >> - SND_JACK_HEADPHONE, &data->hp_jack); >> + SND_JACK_HEADPHONE, 0, &data->hp_jack); >> xonar_ds_handle_hp_jack(chip); > > ...this really ought to be done as part of the commit that adds the > parameter since it breaks the build until this patch is applied. But that's why is a patch series. But as you say, are you suggesting me to propose this changes in one patch only? Felipe Tonello -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/