Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932604Ab3GZWp5 (ORCPT ); Fri, 26 Jul 2013 18:45:57 -0400 Received: from cassiel.sirena.org.uk ([80.68.93.111]:46538 "EHLO cassiel.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932449Ab3GZWpv (ORCPT ); Fri, 26 Jul 2013 18:45:51 -0400 Date: Fri, 26 Jul 2013 23:45:26 +0100 From: Mark Brown To: Felipe Tonello Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , David Henningsson , Wang Xingchao , Jaroslav Kysela Message-ID: <20130726224526.GA9858@sirena.org.uk> References: <1374863133-6745-1-git-send-email-eu@felipetonello.com> <1374863133-6745-5-git-send-email-eu@felipetonello.com> <20130726185609.GY9858@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wOvCr4+o2vlfoINC" Content-Disposition: inline In-Reply-To: X-Cookie: You will be awarded some great honor. User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 94.175.92.69 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 4/4] ALSA: oxygen: Updating jack implementation according new ALSA Jacks X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on cassiel.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2518 Lines: 58 --wOvCr4+o2vlfoINC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 26, 2013 at 12:02:51PM -0700, Felipe Tonello wrote: > On Fri, Jul 26, 2013 at 11:56 AM, Mark Brown wrote: > >> snd_jack_new(chip->card, "Headphone", > >> - SND_JACK_HEADPHONE, &data->hp_jack); > >> + SND_JACK_HEADPHONE, 0, &data->hp_jack); > >> xonar_ds_handle_hp_jack(chip); > > ...this really ought to be done as part of the commit that adds the > > parameter since it breaks the build until this patch is applied. > But that's why is a patch series. But as you say, are you suggesting > me to propose this changes in one patch only? This one should be squashed in, as should the part of the ASoC change that adjusts for the call into the core API. The general idea with a patch series is to split things into smaller chunks so they're easier to understand and review but still keep things working with each change so that things like git bisect continue to be usable. So I guess something like one patch that changes the core jack API to add the index and support jack creation, one to remove the HDA custom implementation and one to add support for specifying the index to the ASoC API and adjust all its users. --wOvCr4+o2vlfoINC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) iQIcBAEBAgAGBQJR8vwCAAoJELSic+t+oim9UqQP/2L5U1lmSidHrDfBy9VeIqZ5 uiI5rWXHCZBi6gHCLEDHaRl6k62NS0ggYTWOrC9L4LTLY27mzrDjFWPPLm9SjDQW +ZoGS1bh7PcOPAVClicLDiaraldc81iAVlXdP7sHLOkqOlRMstlJzUVi2oUHHeXI Cfepp617Ca3N3PchwomCu2kLFKf0fjyQ3DY1nhUW7ishtXwaoKvtoGnc3TwGcLwF 9FXmCGV3U1zumhedU2b2yjgTn7xyXF5qdWwDbohAnC6b92owjwVdPkSsLC0cEfsz T+gjSs0CnclWHH5FWn16Zhzng8+5TfWjkyWhUTcRvhtFjeZSpZMSDOePnbCn9auz zqVzkdSo6AQB105ZG5W5e2ry4Ab7zOOfeJKH5FS7Amjbzpkc9xF+WIW/9PCHfEVw Co+KsTtACrnsYu30s7dHRy3YfiX5r7x1jXkop0FXNG+6GP9nI+yPhn+XSW/+Ht1R R3rHWz1gP024uH1JTgNowFaAPYl6cjaNcp536xHmSY3tB/IANzX0vQ0CYYBOn4zp RTIbMAuOGTFynbDpaw7rYK5nA+P5SjVVEyCZAN+TfspMRvUH0lmxVn30L5gHFSlC QQ/xsWu6FcxHDEMt7p6rMwmlZxBk9PscHCjv7tgJz8XbI9lQ4po0+HsfajAVExmt F1gioOHIWsxIqz3V4Hbq =Xx1q -----END PGP SIGNATURE----- --wOvCr4+o2vlfoINC-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/