Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756749Ab3GZWsz (ORCPT ); Fri, 26 Jul 2013 18:48:55 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:36058 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756666Ab3GZWsy (ORCPT ); Fri, 26 Jul 2013 18:48:54 -0400 MIME-Version: 1.0 In-Reply-To: <20130726224526.GA9858@sirena.org.uk> References: <1374863133-6745-1-git-send-email-eu@felipetonello.com> <1374863133-6745-5-git-send-email-eu@felipetonello.com> <20130726185609.GY9858@sirena.org.uk> <20130726224526.GA9858@sirena.org.uk> Date: Fri, 26 Jul 2013 15:48:52 -0700 Message-ID: Subject: Re: [PATCH 4/4] ALSA: oxygen: Updating jack implementation according new ALSA Jacks From: Felipe Tonello To: Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , David Henningsson , Wang Xingchao , Jaroslav Kysela Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1776 Lines: 42 Mark, On Fri, Jul 26, 2013 at 3:45 PM, Mark Brown wrote: > On Fri, Jul 26, 2013 at 12:02:51PM -0700, Felipe Tonello wrote: >> On Fri, Jul 26, 2013 at 11:56 AM, Mark Brown wrote: > >> >> snd_jack_new(chip->card, "Headphone", >> >> - SND_JACK_HEADPHONE, &data->hp_jack); >> >> + SND_JACK_HEADPHONE, 0, &data->hp_jack); >> >> xonar_ds_handle_hp_jack(chip); > >> > ...this really ought to be done as part of the commit that adds the >> > parameter since it breaks the build until this patch is applied. > >> But that's why is a patch series. But as you say, are you suggesting >> me to propose this changes in one patch only? > > This one should be squashed in, as should the part of the ASoC change > that adjusts for the call into the core API. The general idea with a > patch series is to split things into smaller chunks so they're easier to > understand and review but still keep things working with each change so > that things like git bisect continue to be usable. Sure. > > So I guess something like one patch that changes the core jack API to > add the index and support jack creation, one to remove the HDA custom > implementation and one to add support for specifying the index to the > ASoC API and adjust all its users. I squashed into the HDA one. Perhaps I should send it again? I don't know why, but my gmail is messing with the thread. If you think it's better I can send a v3 with no --in-reply-to option. Felipe Tonello -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/