Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755297Ab3G2Fdj (ORCPT ); Mon, 29 Jul 2013 01:33:39 -0400 Received: from LGEMRELSE7Q.lge.com ([156.147.1.151]:45636 "EHLO LGEMRELSE7Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755166Ab3G2FcZ (ORCPT ); Mon, 29 Jul 2013 01:32:25 -0400 X-AuditID: 9c930197-b7bfbae000000e88-26-51f5fe6583cb From: Joonsoo Kim To: Andrew Morton Cc: Rik van Riel , Mel Gorman , Michal Hocko , "Aneesh Kumar K.V" , KAMEZAWA Hiroyuki , Hugh Dickins , Davidlohr Bueso , David Gibson , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Joonsoo Kim , Wanpeng Li , Naoya Horiguchi , Hillf Danton , Joonsoo Kim Subject: [PATCH 17/18] mm, hugetlb: retry if we fail to allocate a hugepage with use_reserve Date: Mon, 29 Jul 2013 14:32:08 +0900 Message-Id: <1375075929-6119-18-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1375075929-6119-1-git-send-email-iamjoonsoo.kim@lge.com> References: <1375075929-6119-1-git-send-email-iamjoonsoo.kim@lge.com> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1982 Lines: 59 If parallel fault occur, we can fail to allocate a hugepage, because many threads dequeue a hugepage to handle a fault of same address. This makes reserved pool shortage just for a little while and this cause faulting thread who is ensured to have enough reserved hugepages to get a SIGBUS signal. To solve this problem, we already have a nice solution, that is, a hugetlb_instantiation_mutex. This blocks other threads to dive into a fault handler. This solve the problem clearly, but it introduce performance degradation, because it serialize all fault handling. Now, I try to remove a hugetlb_instantiation_mutex to get rid of performance degradation. A prerequisite is that other thread should not get a SIGBUS if they are ensured to have enough reserved pages. For this purpose, if we fail to allocate a new hugepage with use_reserve, we return just 0, instead of VM_FAULT_SIGBUS. use_reserve represent that this user is legimate one who are ensured to have enough reserved pages. This prevent these thread not to get a SIGBUS signal and make these thread retrying fault handling. Signed-off-by: Joonsoo Kim diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 6a9ec69..909075b 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2623,7 +2623,10 @@ retry_avoidcopy: WARN_ON_ONCE(1); } - ret = VM_FAULT_SIGBUS; + if (use_reserve) + ret = 0; + else + ret = VM_FAULT_SIGBUS; goto out_lock; } @@ -2741,7 +2744,10 @@ retry: page = alloc_huge_page(vma, address, use_reserve); if (IS_ERR(page)) { - ret = VM_FAULT_SIGBUS; + if (use_reserve) + ret = 0; + else + ret = VM_FAULT_SIGBUS; goto out; } clear_huge_page(page, address, pages_per_huge_page(h)); -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/