Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754701Ab3G2G6G (ORCPT ); Mon, 29 Jul 2013 02:58:06 -0400 Received: from mail-ob0-f175.google.com ([209.85.214.175]:46463 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752628Ab3G2G6D (ORCPT ); Mon, 29 Jul 2013 02:58:03 -0400 MIME-Version: 1.0 In-Reply-To: <20130726132120.5b9cf32f@amdc308.digital.local> References: <1370502472-7249-1-git-send-email-l.majewski@samsung.com> <1374770011-22171-1-git-send-email-l.majewski@samsung.com> <1374770011-22171-6-git-send-email-l.majewski@samsung.com> <20130726132120.5b9cf32f@amdc308.digital.local> Date: Mon, 29 Jul 2013 12:28:02 +0530 Message-ID: Subject: Re: [PATCH v6 5/8] cpufreq:boost:Kconfig: Provide support for software managed BOOST From: Viresh Kumar To: Lukasz Majewski Cc: "Rafael J. Wysocki" , Zhang Rui , Eduardo Valentin , "cpufreq@vger.kernel.org" , Linux PM list , Jonghwa Lee , Lukasz Majewski , linux-kernel , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Kukjin Kim , durgadoss.r@intel.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1554 Lines: 36 On 26 July 2013 16:51, Lukasz Majewski wrote: > On Fri, 26 Jul 2013 15:54:56 +0530 Viresh Kumar wrote, >> On 25 July 2013 22:03, Lukasz Majewski wrote: >> > +config CPU_FREQ_BOOST_SW >> > + bool >> >> Invisible is fine but this must be disabled by default and must >> depend on thermal, rather than moving dependency on platform's >> config. > > The CPU_FREQ_BOOST_SW [1] is a generic flag (invisible). > > I will add "default n" to it. Leave it.. We don't need it now.. that's how these kind of config options are defined as they are disabled by default. > Depending only on [3], results at situation where SW BOOST can be > enabled at x86 or ARM target with only generic THERMAL support (which > doesn't protect from overheating). I had a similar concern.. Currently also we aren't stopping anybody to enable boost. By selecting thermal from CPU_FREQ_BOOST_SW, atleast we are communicating this very well to developers that they need something else as well. And currently we only have thermal as a source for telling when to block boost but it can be something else too.. I never said, don't use EXYNOS_THERMAL, its good to have a dependency on it in the Exynos specific config for boost, but I wanted normal sw boost also to depend on thermal.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/