Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754811Ab3G2HBc (ORCPT ); Mon, 29 Jul 2013 03:01:32 -0400 Received: from mail-ob0-f169.google.com ([209.85.214.169]:58868 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752412Ab3G2HBa (ORCPT ); Mon, 29 Jul 2013 03:01:30 -0400 MIME-Version: 1.0 In-Reply-To: <20130726132617.567f2cbf@amdc308.digital.local> References: <1370502472-7249-1-git-send-email-l.majewski@samsung.com> <1374770011-22171-1-git-send-email-l.majewski@samsung.com> <1374770011-22171-7-git-send-email-l.majewski@samsung.com> <20130726132617.567f2cbf@amdc308.digital.local> Date: Mon, 29 Jul 2013 12:31:30 +0530 Message-ID: Subject: Re: [PATCH v6 6/8] cpufreq:exynos:Extend Exynos cpufreq driver to support boost framework From: Viresh Kumar To: Lukasz Majewski Cc: "Rafael J. Wysocki" , Zhang Rui , Eduardo Valentin , "cpufreq@vger.kernel.org" , Linux PM list , Jonghwa Lee , Lukasz Majewski , linux-kernel , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Kukjin Kim , durgadoss.r@intel.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1358 Lines: 32 On 26 July 2013 16:56, Lukasz Majewski wrote: > On Fri, 26 Jul 2013 15:56:53 +0530 Viresh Kumar wrote, >> On 25 July 2013 22:03, Lukasz Majewski wrote: >> >> > diff --git a/drivers/cpufreq/exynos-cpufreq.c >> > b/drivers/cpufreq/exynos-cpufreq.c index 9ae1871..175172d9 100644 >> > --- a/drivers/cpufreq/exynos-cpufreq.c >> > +++ b/drivers/cpufreq/exynos-cpufreq.c >> > @@ -270,6 +270,9 @@ static int exynos_cpufreq_cpu_exit(struct >> > cpufreq_policy *policy) >> > >> > static struct freq_attr *exynos_cpufreq_attr[] = { >> > &cpufreq_freq_attr_scaling_available_freqs, >> > +#ifdef CONFIG_CPU_FREQ_BOOST_SW > ^^^^^^^^^^^^^^^^^^^^^^^^^ [*] >> >> Use ARM_EXYNOS_CPU_FREQ_BOOST_SW instead. > > For the reasons explained at [PATCH v6 5/8] I would prefer to leave [*] > here. I don't see how that reasoning fit here. This is exynos code and you must use exynos specific boost Kconfig option here.. Otherwise It might be enabled without Exynos specific option, if somebody else has selected CONFIG_CPU_FREQ_BOOST_SW in a multi platform kernel, -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/