Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 10 Oct 2002 17:44:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 10 Oct 2002 17:44:03 -0400 Received: from mg02.austin.ibm.com ([192.35.232.12]:55984 "EHLO mg02.austin.ibm.com") by vger.kernel.org with ESMTP id ; Thu, 10 Oct 2002 17:44:00 -0400 Content-Type: text/plain; charset=US-ASCII From: Kevin Corry Organization: IBM To: Andi Kleen Subject: Re: [PATCH] EVMS core (3/9) discover.c Date: Thu, 10 Oct 2002 16:15:34 -0500 X-Mailer: KMail [version 1.2] Cc: linux-kernel@vger.kernel.org, evms-devel@lists.sourceforge.net References: <02101014305502.17770@boiler.suse.lists.linux.kernel> <02101014352905.17770@boiler.suse.lists.linux.kernel> In-Reply-To: MIME-Version: 1.0 Message-Id: <0210101615340C.17770@boiler> Content-Transfer-Encoding: 7BIT Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 652 Lines: 21 On Thursday 10 October 2002 15:48, Andi Kleen wrote: > Kevin Corry writes: > > + > > + if (!gd) { > > + gd = alloc_disk(); > > + BUG_ON(!gd); > > BUG_ON ? Can't this fail for legal reasons? Yes, it can. This, and a couple other incorrect BUG_ON() statements have been fixed to fail gracefully. Thanks for catching this. -- Kevin Corry corryk@us.ibm.com http://evms.sourceforge.net/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/