Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754933Ab3G2Jwy (ORCPT ); Mon, 29 Jul 2013 05:52:54 -0400 Received: from ns.mm-sol.com ([212.124.72.66]:46901 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752397Ab3G2Jww (ORCPT ); Mon, 29 Jul 2013 05:52:52 -0400 Message-ID: <1375091521.1956.54.camel@iivanov-dev.int.mm-sol.com> Subject: Re: [PATCH v2] tty: serial: Add initial MSM UART High Speed Lite driver From: "Ivan T. Ivanov" To: David Brown Cc: gregkh@linuxfoundation.org, grant.likely@linaro.org, rob.herring@calxeda.com, rob@landley.net, jslaby@suse.cz, devicetree-discuss@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, mrana@codeaurora.org, sambley@codeaurora.org Date: Mon, 29 Jul 2013 12:52:01 +0300 In-Reply-To: <20130726215023.GA1470@codeaurora.org> References: <1374476749-12763-1-git-send-email-iivanov@mm-sol.com> <20130726215023.GA1470@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1241 Lines: 35 Hi David, On Fri, 2013-07-26 at 14:50 -0700, David Brown wrote: > On Mon, Jul 22, 2013 at 10:05:48AM +0300, Ivan T. Ivanov wrote: > >From: "Ivan T. Ivanov" > > > >This is a tty driver with console support for Qualcomm's UART > >controllers found in the MSM8974 chipsets. Driver is completely > >based on implementation found in codeaurora.org msm_serial_hs_lite > >with Android dependences removed. Other changes include, moved to > >device managed resources and few cleanups. > > > >Driver functionality was tested in LEGACY_HSUART and BLSP_HSUART mode. > > Ivan, do we need this driver with the fixes Stephen Boyd posted that > are supposed to fix the problems with the existing msm_serial.c > driver? If a single driver can correctly support both devices, that > seems like a better solution to me. I have just tested Stephen's changes and they worked for me on 8074 based dragon board, so I am fine to drop my port of the HSL driver. Regards, Ivan > > David > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/