Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753648Ab3G2ME2 (ORCPT ); Mon, 29 Jul 2013 08:04:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34801 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750906Ab3G2ME1 (ORCPT ); Mon, 29 Jul 2013 08:04:27 -0400 Date: Mon, 29 Jul 2013 14:05:52 +0200 Message-ID: From: Takashi Iwai To: Mark Brown Cc: Felipe Tonello , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, David Henningsson , Wang Xingchao , Jaroslav Kysela Subject: Re: [PATCH 1/4] ALSA: Added jack detection kcontrol support In-Reply-To: <20130727122524.GH9858@sirena.org.uk> References: <1374863133-6745-1-git-send-email-eu@felipetonello.com> <1374863133-6745-2-git-send-email-eu@felipetonello.com> <20130726185458.GX9858@sirena.org.uk> <20130726224813.GB9858@sirena.org.uk> <20130727122524.GH9858@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1264 Lines: 32 At Sat, 27 Jul 2013 13:25:24 +0100, Mark Brown wrote: > > On Fri, Jul 26, 2013 at 04:13:40PM -0700, Felipe Tonello wrote: > > On Fri, Jul 26, 2013 at 3:48 PM, Mark Brown wrote: > > > >> > What I'd expect to happen here is that for multi function jacks we > > >> > create a control per function if the controls are valid. > > > Ok, so the idea is just to change the control to type integer instead > > of boolean, right? > > Because as you say, the user will be able to check the type of jack > > based on the status value, right? > > It might be more idiomatic and more compatible with userspace to create > multiple controls for the jack, there was some discussion of this in the > past I think but I can't remember the result. I also forget the end result :) Another option would be to make an enum control, but multiple boolean controls are easier in the end. The headset controls of HD-audio are represented in that way, too (because HD-audio specification can't tell better). Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/