Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754047Ab3G2MIu (ORCPT ); Mon, 29 Jul 2013 08:08:50 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34946 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751245Ab3G2MIt (ORCPT ); Mon, 29 Jul 2013 08:08:49 -0400 Date: Mon, 29 Jul 2013 14:10:18 +0200 Message-ID: From: Takashi Iwai To: Felipe Tonello Cc: Mark Brown , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, David Henningsson , Wang Xingchao , Jaroslav Kysela Subject: Re: [PATCH 4/4] ALSA: oxygen: Updating jack implementation according new ALSA Jacks In-Reply-To: References: <1374863133-6745-1-git-send-email-eu@felipetonello.com> <1374863133-6745-5-git-send-email-eu@felipetonello.com> <20130726185609.GY9858@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.2 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1651 Lines: 46 At Fri, 26 Jul 2013 12:02:51 -0700, Felipe Tonello wrote: > > Hi Mark, > > On Fri, Jul 26, 2013 at 11:56 AM, Mark Brown wrote: > > On Fri, Jul 26, 2013 at 11:25:33AM -0700, Felipe F. Tonello wrote: > >> From: "Felipe F. Tonello" > >> > >> ALSA standard jacks already are implemented using ALSA KControl. > >> So there is no need implement that itself or to use snd_jack > >> for input events only. > > > > Similar changlog comment as on the ASoC patch and... > > Ok. > > > > >> snd_jack_new(chip->card, "Headphone", > >> - SND_JACK_HEADPHONE, &data->hp_jack); > >> + SND_JACK_HEADPHONE, 0, &data->hp_jack); > >> xonar_ds_handle_hp_jack(chip); > > > > ...this really ought to be done as part of the commit that adds the > > parameter since it breaks the build until this patch is applied. > > But that's why is a patch series. But as you say, are you suggesting > me to propose this changes in one patch only? The basic rule of the patch series is: - they are split in a logical manner - each commit must not break the build The second rule is important especially for bisection and backporting. You could have done in a different way (e.g. adding a new function like snd_jack_new_with_index() instead of changing snd_jack_new() itself). Which way is better, depends on the implementation details. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/