Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754317Ab3G2MQh (ORCPT ); Mon, 29 Jul 2013 08:16:37 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:51743 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754246Ab3G2MQf (ORCPT ); Mon, 29 Jul 2013 08:16:35 -0400 Message-ID: <51F65D1F.9050402@cogentembedded.com> Date: Mon, 29 Jul 2013 16:16:31 +0400 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: Joe Perches , Lan Tianyu , ACPI Devel Maling List , LKML , Linux PM list , Yinghai Lu , Bjorn Helgaas , Aaron Lu , Tejun Heo , linux-ide@vger.kernel.org Subject: Re: [PATCH 2/3] ACPI / PM: Make messages in acpi_device_set_power() print device names References: <10433383.dueoNg39qi@vostro.rjw.lan> <1375067513.2075.27.camel@joe-AO722> <1782275.A7JEhQIj8Q@vostro.rjw.lan> In-Reply-To: <1782275.A7JEhQIj8Q@vostro.rjw.lan> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1018 Lines: 32 Hello. On 29-07-2013 16:17, Rafael J. Wysocki wrote: [...] >>>> @@ -166,20 +166,20 @@ int acpi_device_set_power(struct acpi_de >> [] >>>> if (device->parent && (state < device->parent->power.state)) { >>>> - printk(KERN_WARNING PREFIX >>>> - "Cannot set device to a higher-powered" >>>> - " state than parent\n"); >>>> + dev_warn(&device->dev, "Cannot transition to a higher-powered " >>>> + "state than parent\n"); >> coalesce format please. > I can, but then it'll cross the 80 columns boundary. It's not a problem with checkpatch.pl anymore. Contrariwise, it whines about the broken up string literals, AFAIR. > Thanks, > Rafael WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/