Date: Mon, 29 Jul 2013 19:02:09 +0400
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Cc: Pavel Emelyanov <xemul@parallels.com>, Linux MM <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        Matt Mackall <mpm@selenic.com>,
        Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] mm: Save soft-dirty bits on file pages
Message-ID: <20130729150209.GO2524@moon>
References: <20130726201807.GJ8661@moon>
 <51F67777.6060609@parallels.com>
 <20130729141417.GM2524@moon>
 <878v0ps98x.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <878v0ps98x.fsf@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 739
Lines: 22

On Mon, Jul 29, 2013 at 08:28:54PM +0530, Aneesh Kumar K.V wrote:
> >
> > If only I'm not missing something obvious, this code compiles not only on x86,
> > CONFIG_MEM_SOFT_DIRTY depends on x86 (otherwise I'll have to implement
> > pte_soft_dirty for all archs).
> 
> why not
> 
> #ifndef pte_soft_dirty 
> #define pte_soft_dirty(pte) 0 
> #endif
> 
> and on x86 
> #define pte_soft_dirty pte_soft_dirty

Yeah, either this way, either to use asm-generic (later I think
more preferred), thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/