Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932199Ab3G2Rzk (ORCPT ); Mon, 29 Jul 2013 13:55:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31994 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752597Ab3G2Rzj (ORCPT ); Mon, 29 Jul 2013 13:55:39 -0400 Date: Mon, 29 Jul 2013 19:50:08 +0200 From: Oleg Nesterov To: Steven Rostedt , Masami Hiramatsu Cc: Alexander Z Lam , Arnaldo Carvalho de Melo , David Sharp , Frederic Weisbecker , Greg Kroah-Hartman , Ingo Molnar , Peter Zijlstra , Srikar Dronamraju , Vaibhav Nagarnaik , "zhangwei(Jovi)" , linux-kernel@vger.kernel.org Subject: [PATCH v2 0/1] tracing: trace_remove_event_call() should fail if call/file is in use Message-ID: <20130729175008.GA26284@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1259 Lines: 37 Hello. On top of "[PATCH v2 0/6] tracing: open/delete fixes" series. Perhaps this series should be updated, Masami has some concerns. But it seems that you both mostly agree with these changes, so let me send the "last" patch for review. The last change in kernel/trace/trace_events.c we need to close the problems with create/use/delete (at least those which I know ;). Now we are ready to change trace_kprobe.c and trace_uprobe.c, Steven already has the patches. Changes: - remove the TRACE_EVENT_FL_REF_MASK (which we do not have) check. We rely on the previous changes, we do not care if someone have an opened file, event_enable_write/etc can do nothing but fail after we do remove_event_file_dir(). - Add the comment and a note into the changelog to explain why we still need to check FTRACE_EVENT_FL_ENABLED. Oleg. include/linux/ftrace_event.h | 2 +- kernel/trace/trace_events.c | 35 +++++++++++++++++++++++++++++++++-- 2 files changed, 34 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/