Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755854Ab3G3NIs (ORCPT ); Tue, 30 Jul 2013 09:08:48 -0400 Received: from mail-pb0-f47.google.com ([209.85.160.47]:54742 "EHLO mail-pb0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755780Ab3G3NIo (ORCPT ); Tue, 30 Jul 2013 09:08:44 -0400 MIME-Version: 1.0 In-Reply-To: <1375187900-17582-1-git-send-email-B44344@freescale.com> References: <1375187900-17582-1-git-send-email-B44344@freescale.com> Date: Tue, 30 Jul 2013 15:08:43 +0200 X-Google-Sender-Auth: 64bMi3pNwtiV2KD7LouOj-TDgcw Message-ID: Subject: Re: [PATCH 0/2] Make PPC macro spin_event_timeout() architecture independent From: Geert Uytterhoeven To: Arpit Goel Cc: Russell King , Hirokazu Takata , Philip Blundell , Martin Schwidefsky , Heiko Carstens , linux390@de.ibm.com, "David S. Miller" , Rob Herring , Arnd Bergmann , Stephen Boyd , Stephen Warren , John Stultz , Jesper Nilsson , Greg KH , Sam Ravnborg , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org, "Linux/m68k" , linux-s390 , sparclinux Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2117 Lines: 50 On Tue, Jul 30, 2013 at 2:38 PM, Arpit Goel wrote: > This patch-set moves USECS_PER_JIFFY to architecture timex.h from architecture > specific C files. Patch-set further uses this to make PPC macro > spin_event_timeout() architecture independent. This change enables drivers to > use spin_event_timeout() even in non-PowerPC based SoC's. > > This patchset has been compiled for ARM, PowerPC and x86. > > Patch[1/2] : Moves USECS_PER_JIFFY to architecture specific timex.h files from > architecture specific C files. > arch/arm/include/asm/timex.h | 2 ++ > arch/arm/kernel/time.c | 3 --- > arch/m32r/include/asm/timex.h | 2 ++ > arch/m32r/kernel/time.c | 3 --- > arch/m68k/hp300/time.c | 4 +--- > arch/m68k/include/asm/timex.h | 2 ++ > arch/s390/include/asm/timex.h | 2 ++ > arch/s390/kernel/time.c | 2 -- > arch/sparc/include/asm/timex_32.h | 2 ++ > arch/sparc/include/asm/timex_64.h | 2 ++ > arch/sparc/kernel/pcic.c | 1 - As the definition is the same on all architectures, why not move it to ? > Patch[2/2] : Converts PPC macro spin_event_timeout() in architecture independent > macro. > include/linux/delay.h | 40 +++++++++++++++++++++++++++++++++++++++ After your first patch, USECS_PER_JIFFY is still available only on arm/m32r/m68k/s390/sparc. What about other architectures? If anyone uses spin_event_timeout() on e.g. x86, it will fail to compile. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/