Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756782Ab3G3PXy (ORCPT ); Tue, 30 Jul 2013 11:23:54 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:42569 "EHLO e23smtp09.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756486Ab3G3PXt (ORCPT ); Tue, 30 Jul 2013 11:23:49 -0400 Date: Mon, 29 Jul 2013 10:06:24 -0500 From: Seth Jennings To: Cody P Schafer Cc: Andrew Morton , LKML , Linux MM , David Woodhouse , Rik van Riel , Michel Lespinasse Subject: Re: [PATCH 2/5] rbtree: add rbtree_postorder_for_each_entry_safe() helper Message-ID: <20130729150624.GB4381@variantweb.net> References: <1374873223-25557-1-git-send-email-cody@linux.vnet.ibm.com> <1374873223-25557-3-git-send-email-cody@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1374873223-25557-3-git-send-email-cody@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13073102-3568-0000-0000-00000401FFC1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1865 Lines: 52 On Fri, Jul 26, 2013 at 02:13:40PM -0700, Cody P Schafer wrote: > Because deletion (of the entire tree) is a relatively common use of the > rbtree_postorder iteration, and because doing it safely means fiddling > with temporary storage, provide a helper to simplify postorder rbtree > iteration. > > Signed-off-by: Cody P Schafer > --- > include/linux/rbtree.h | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/include/linux/rbtree.h b/include/linux/rbtree.h > index 2879e96..64ab98b 100644 > --- a/include/linux/rbtree.h > +++ b/include/linux/rbtree.h > @@ -85,4 +85,21 @@ static inline void rb_link_node(struct rb_node * node, struct rb_node * parent, > *rb_link = node; > } > > +/** > + * rbtree_postorder_for_each_entry_safe - iterate over rb_root in post order of > + * given type safe against removal of rb_node entry > + * > + * @pos: the 'type *' to use as a loop cursor. > + * @n: another 'type *' to use as temporary storage > + * @root: 'rb_root *' of the rbtree. > + * @field: the name of the rb_node field within 'type'. > + */ > +#define rbtree_postorder_for_each_entry_safe(pos, n, root, field) \ > + for (pos = rb_entry(rb_first_postorder(root), typeof(*pos), field),\ > + n = rb_entry(rb_next_postorder(&pos->field), \ > + typeof(*pos), field); \ > + &pos->field; \ > + pos = n, \ > + n = rb_entry(rb_next_postorder(&pos->field), typeof(*pos), field)) One too many spaces. Also mix of tabs and spaces is weird, but checkpatch doesn't complain so... Seth > + > #endif /* _LINUX_RBTREE_H */ > -- > 1.8.3.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/