Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756549Ab3G3RxO (ORCPT ); Tue, 30 Jul 2013 13:53:14 -0400 Received: from mail-ve0-f171.google.com ([209.85.128.171]:44237 "EHLO mail-ve0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754396Ab3G3RxL (ORCPT ); Tue, 30 Jul 2013 13:53:11 -0400 MIME-Version: 1.0 In-Reply-To: <1375202858-28470-2-git-send-email-leif.lindholm@linaro.org> References: <1375202858-28470-1-git-send-email-leif.lindholm@linaro.org> <1375202858-28470-2-git-send-email-leif.lindholm@linaro.org> Date: Tue, 30 Jul 2013 10:53:10 -0700 Message-ID: Subject: Re: [PATCH 1/4] efi: provide a generic efi_config_init() From: Tony Luck To: Leif Lindholm Cc: "linux-efi@vger.kernel.org" , Linux Kernel Mailing List , "linux-ia64@vger.kernel.org" , Matt Fleming , "H. Peter Anvin" , Thomas Gleixner , patches@linaro.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 22 On Tue, Jul 30, 2013 at 9:47 AM, Leif Lindholm wrote: > + /* > + * Let's see what config tables the firmware passed to us. > + */ > + config_tables = early_mememap(efi.systab->tables, > + efi.systab->nr_tables * sz); Breaks bisection on ia64 ... you use early_mememap() here, but don't define it on ia64 until patch 3/4. So I get: drivers/firmware/efi/efi.c: In function 'efi_config_init': drivers/firmware/efi/efi.c:200: error: implicit declaration of function 'early_memremap' drivers/firmware/efi/efi.c:201: warning: assignment makes pointer from integer without a cast -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/