Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757857Ab3G3Vk3 (ORCPT ); Tue, 30 Jul 2013 17:40:29 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:44822 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756870Ab3G3Vk2 (ORCPT ); Tue, 30 Jul 2013 17:40:28 -0400 Message-ID: <51F832C9.9000900@wwwdotorg.org> Date: Tue, 30 Jul 2013 15:40:25 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Russell King CC: ebiederm@xmission.com, Simon Horman , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Will Deacon , Stephen Warren Subject: Re: [PATCH] ARM: kexec: validate CPU hotplug support References: <1373582931-11956-1-git-send-email-swarren@wwwdotorg.org> <51E958CC.5070906@wwwdotorg.org> In-Reply-To: <51E958CC.5070906@wwwdotorg.org> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 24 On 07/19/2013 09:18 AM, Stephen Warren wrote: > On 07/11/2013 04:48 PM, Stephen Warren wrote: >> From: Stephen Warren >> >> Architectures should fully validate whether kexec is possible as part of >> machine_kexec_prepare(), so that user-space's kexec_load() operation can >> report any problems. Performing validation in machine_kexec() itself is >> too late, since it is not allowed to return. >> >> Prior to this patch, ARM's machine_kexec() was testing after-the-fact >> whether machine_kexec_prepare() was able to disable all but one CPU. >> Instead, modify machine_kexec_prepare() to validate all conditions >> necessary for machine_kexec_prepare()'s to succeed. BUG if the validation >> succeeded, yet disabling the CPUs didn't actually work. > > Russell, does this look good to put into the ARM patch tracker? I put this in the patch tracker since I assume that no response means no objection. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/