Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758614Ab3GaAIP (ORCPT ); Tue, 30 Jul 2013 20:08:15 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:51722 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755837Ab3GaAIO (ORCPT ); Tue, 30 Jul 2013 20:08:14 -0400 Message-ID: <51F8556A.1010300@wwwdotorg.org> Date: Tue, 30 Jul 2013 18:08:10 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Hanumant Singh CC: Linus Walleij , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Bjorn Andersson , "Bird, Tim" , ext Tony Lindgren Subject: Re: [PATCH] pinctrl: msm: Add support for MSM TLMM pinmux References: <1374702089-2832-1-git-send-email-hanumant@codeaurora.org> <51F82BCC.1080409@codeaurora.org> <51F82E9F.9010309@wwwdotorg.org> <51F853BF.9040007@codeaurora.org> In-Reply-To: <51F853BF.9040007@codeaurora.org> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1629 Lines: 34 On 07/30/2013 06:01 PM, Hanumant Singh wrote: > On 7/30/2013 2:22 PM, Stephen Warren wrote: >> On 07/30/2013 03:10 PM, hanumant wrote: >> ... >>> We actually have the same TLMM pinmux used by several socs of a family. >>> The number of pins on each soc may vary. >>> Also a given soc gets used in a number of boards. >>> The device tree for a given soc is split into the different boards that >>> its in ie the boards inherit a common soc.dtsi but have separate dts. >>> The boards for the same soc may use different pin groups for >>> accomplishing a function, since we have multiple i2c, spi uart etc >>> peripheral instances on a soc. A different instance of each of the above >>> peripherals, can be used in different boards, utilizing different >>> or subset of same pin groups. >>> Thus I would need to have multiple C files for one soc, based on the >>> boards that it goes into. >> >> The pinctrl driver should be exposing the raw capabilities of the HW. >> All the board-specific configuration should be expressed in DT. So, the >> driver shouldn't have to know anything about different boards at >> compile-time. >> > I agree, so I wanted to keep the pin grouping information in DT, we > already have a board based differentiation of dts files in DT, for the > same soc. That's the opposite of what I was saying. Pin groups are a feature of the SoC design, not the board. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/