Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758637Ab3GaA1q (ORCPT ); Tue, 30 Jul 2013 20:27:46 -0400 Received: from zetta.elopez.com.ar ([199.30.59.35]:56410 "EHLO zetta.elopez.com.ar" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756990Ab3GaA1o (ORCPT ); Tue, 30 Jul 2013 20:27:44 -0400 Message-ID: <51F859F5.70501@elopez.com.ar> Date: Tue, 30 Jul 2013 21:27:33 -0300 From: =?ISO-8859-1?Q?Emilio_L=F3pez?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Maxime Ripard CC: Mike Turquette , kevin.z.m.zh@gmail.com, sunny@allwinnertech.com, shuge@allwinnertech.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] clk: sunxi: Allow to specify the divider width from the dividers data References: <1375195462-19566-1-git-send-email-maxime.ripard@free-electrons.com> <1375195462-19566-3-git-send-email-maxime.ripard@free-electrons.com> In-Reply-To: <1375195462-19566-3-git-send-email-maxime.ripard@free-electrons.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2295 Lines: 81 El 30/07/13 11:44, Maxime Ripard escribi?: > The divider width used to be hardcoded. Some A31 dividers are no longer > with the hardcoded width, so we need to make it specific to each divider > and set it in the dividers data. > > Signed-off-by: Maxime Ripard Looks good to me, Reviewed-by: Emilio L?pez > --- > drivers/clk/sunxi/clk-sunxi.c | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c > index 3c91888..6e9cbc9 100644 > --- a/drivers/clk/sunxi/clk-sunxi.c > +++ b/drivers/clk/sunxi/clk-sunxi.c > @@ -277,26 +277,28 @@ static void __init sunxi_mux_clk_setup(struct device_node *node, > * sunxi_divider_clk_setup() - Setup function for simple divider clocks > */ > > -#define SUNXI_DIVISOR_WIDTH 2 > - > struct div_data { > - u8 shift; > - u8 pow; > + u8 shift; > + u8 pow; > + u8 width; > }; > > static const __initconst struct div_data sun4i_axi_data = { > - .shift = 0, > - .pow = 0, > + .shift = 0, > + .pow = 0, > + .width = 2, > }; Is there a style rule governing the use of tabs/spaces on structs? Maybe we should do this alignment cleanup on the full file some time. > > static const __initconst struct div_data sun4i_ahb_data = { > - .shift = 4, > - .pow = 1, > + .shift = 4, > + .pow = 1, > + .width = 2, > }; > > static const __initconst struct div_data sun4i_apb0_data = { > - .shift = 8, > - .pow = 1, > + .shift = 8, > + .pow = 1, > + .width = 2, > }; > > static void __init sunxi_divider_clk_setup(struct device_node *node, > @@ -312,7 +314,7 @@ static void __init sunxi_divider_clk_setup(struct device_node *node, > clk_parent = of_clk_get_parent_name(node, 0); > > clk = clk_register_divider(NULL, clk_name, clk_parent, 0, > - reg, data->shift, SUNXI_DIVISOR_WIDTH, > + reg, data->shift, data->width, > data->pow ? CLK_DIVIDER_POWER_OF_TWO : 0, > &clk_lock); > if (clk) { > Thanks! Emilio -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/