Message-ID: <51F8E1AD.4070708@linux.vnet.ibm.com>
Date: Wed, 31 Jul 2013 15:36:37 +0530
From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: "Luck, Tony" <tony.luck@intel.com>
CC: "gong.chen@linux.intel.com" <gong.chen@linux.intel.com>,
        "bp@suse.de" <bp@suse.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/mce: Pay no attention to 'F' bit in MCACOD when parsing
 'UC' errors.
References: <20130724061626.GA18995@gchen.bj.intel.com> <20130725103647.5009.92648.stgit@localhost.localdomain> <3908561D78D1C84285E8C5FCA982C28F31C9F32B@ORSMSX106.amr.corp.intel.com>
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F31C9F32B@ORSMSX106.amr.corp.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1286
Lines: 34

On 07/25/2013 11:31 PM, Luck, Tony wrote:
> 	MCESEV(
> +		PANIC, "Action required but kernel thread is not continuable",
> +		SER, MASK(MCI_STATUS_OVER|MCI_UC_SAR|MCI_ADDR, MCI_UC_SAR|MCI_ADDR),
> +		MCGMASK(MCG_STATUS_RIPV|MCG_STATUS_EIPV, MCG_STATUS_RIPV|MCG_STATUS_EIPV),
> +		KERNEL
> +		),
> +	MCESEV(
>   		AR, "Action required: data load error in a user process",
>   		SER, MASK(MCI_STATUS_OVER|MCI_UC_SAR|MCI_ADDR|MCACOD, MCI_UC_SAR|MCI_ADDR|MCACOD_DATA),
>   		USER
>
> This just gives us a better panic message. Right?  Without this we'd keep walking the
> severity table until we hit the "Action required: unknown MCACOD" entry which will
> match and force a panic anyway.

Yes, that's correct. But I felt it would be good to have this entry to 
make it explicit.

>
> So I might look for better wording.  As far as the h/w is concerned the thread is continuable.
> Linux is just not smart enough (yet) to take the required recovery action.

Ok, how about: "Action required but unable to recover kernel thread"


Thanks,
Naveen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/