Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757147Ab3GaLJh (ORCPT ); Wed, 31 Jul 2013 07:09:37 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:32771 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753905Ab3GaLJf (ORCPT ); Wed, 31 Jul 2013 07:09:35 -0400 Date: Wed, 31 Jul 2013 12:09:29 +0100 From: Lee Jones To: "Kim, Milo" Cc: "devicetree@vger.kernel.org" , "Samuel Ortiz (sameo@linux.intel.com)" , "broonie@kernel.org" , "linus.walleij@linaro.org" , "thierry.reding@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" Subject: Re: [PATCH v2 4/4] Documentation: dt: bindings: add LP3943 bindings Message-ID: <20130731110929.GG13298@lee--X1> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1996 Lines: 52 On Tue, 30 Jul 2013, Kim, Milo wrote: > Bindings for LP3943 MFD, GPIO and PWM controller are added. > > Cc: devicetree@vger.kernel.org > Cc: Lee Jones > Cc: Linus Walleij > Cc: Samuel Ortiz > Cc: Thierry Reding > Signed-off-by: Milo Kim > --- > .../devicetree/bindings/gpio/gpio-lp3943.txt | 42 +++++++++++++ > Documentation/devicetree/bindings/mfd/lp3943.txt | 33 ++++++++++ > .../devicetree/bindings/pwm/pwm-lp3943.txt | 65 ++++++++++++++++++++ > 3 files changed, 140 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-lp3943.txt > create mode 100644 Documentation/devicetree/bindings/mfd/lp3943.txt > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-lp3943.txt > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-lp3943.txt b/Documentation/devicetree/bindings/gpio/gpio-lp3943.txt > new file mode 100644 > index 0000000..952fefd > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/gpio-lp3943.txt > @@ -0,0 +1,42 @@ > +TI/National Semiconductor LP3943 GPIO controller > + > +Required properties: > + - compatible: "ti,lp3943-gpio" > + - gpio-controller: device node as a GPIO controller > + - #gpio-cells: Should be two. > + 1) pin number offset > + 2) GPIO polarity > + 0 = active high, 1 = active low Please use the defines instead on '0' and '1': include/dt-bindings/gpio/gpio.h > + gpios = <&gpioex 9 1>; /* active-low */ > + gpios = <&gpioex 10 1>; /* active-low */ -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/