Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760342Ab3GaOYU (ORCPT ); Wed, 31 Jul 2013 10:24:20 -0400 Received: from merlin.infradead.org ([205.233.59.134]:52122 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760136Ab3GaOYR (ORCPT ); Wed, 31 Jul 2013 10:24:17 -0400 Date: Wed, 31 Jul 2013 16:24:05 +0200 From: Peter Zijlstra To: Arnaldo Carvalho de Melo Cc: Adrian Hunter , linux-kernel@vger.kernel.org, David Ahern , Frederic Weisbecker , Jiri Olsa , Mike Galbraith , Namhyung Kim , Paul Mackerras , Stephane Eranian , Ingo Molnar Subject: Re: [PATCH V2 1/9] perf tools: add test for reading object code Message-ID: <20130731142405.GB3008@twins.programming.kicks-ass.net> References: <1375218838-31042-1-git-send-email-adrian.hunter@intel.com> <1375218838-31042-2-git-send-email-adrian.hunter@intel.com> <20130731141732.GD3614@ghostprotocols.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130731141732.GD3614@ghostprotocols.net> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 23 On Wed, Jul 31, 2013 at 11:17:32AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Jul 31, 2013 at 12:13:50AM +0300, Adrian Hunter escreveu: > > Using the information in mmap events, perf tools can read object > > code associated with sampled addresses. A test is added that > > compares bytes read by perf with the same bytes read using > > objdump. > > So this parses objdump output, and we also already have the annotation > logic that does that too, have you thought about having common routines > for these two cases? > Or better yet, stop using objdump like this and start using libbfd directly. The only reason we did horrible things like parsing objdump output is because nobody knew how the underlying stuff actually worked and we wanted to have something quick. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/