Message-ID: <1375289503.5418.6.camel@gandalf.local.home>
Subject: Re: [PATCH v2 0/1] tracing: trace_remove_event_call() should fail
 if call/file is in use
From: Steven Rostedt <rostedt@goodmis.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Alexander Z Lam <azl@google.com>,
        Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
        David Sharp <dhsharp@google.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
        Vaibhav Nagarnaik <vnagarnaik@google.com>,
        "zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
        linux-kernel@vger.kernel.org
Date: Wed, 31 Jul 2013 12:51:43 -0400
In-Reply-To: <20130729175008.GA26284@redhat.com>
References: <20130729175008.GA26284@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1557
Lines: 48

On Mon, 2013-07-29 at 19:50 +0200, Oleg Nesterov wrote:
> Hello.
> 
> On top of "[PATCH v2 0/6] tracing: open/delete fixes" series.
> 
> Perhaps this series should be updated, Masami has some concerns.
> But it seems that you both mostly agree with these changes, so
> let me send the "last" patch for review.
> 
> The last change in kernel/trace/trace_events.c we need to close the
> problems with create/use/delete (at least those which I know ;).
> 
> Now we are ready to change trace_kprobe.c and trace_uprobe.c, Steven
> already has the patches.

Can you refresh my memory. My INBOX is quite full. What were the
subjects for these patches? This fix has lots of different threads, not
to mention versions.

Thanks,

-- Steve

> 
> Changes:
> 
> 	- remove the TRACE_EVENT_FL_REF_MASK (which we do not have)
> 	  check.
> 
> 	  We rely on the previous changes, we do not care if someone
> 	  have an opened file, event_enable_write/etc can do nothing
> 	  but fail after we do remove_event_file_dir().
> 
> 	- Add the comment and a note into the changelog to explain
> 	  why we still need to check FTRACE_EVENT_FL_ENABLED.
> 
> Oleg.
> 
>  include/linux/ftrace_event.h |    2 +-
>  kernel/trace/trace_events.c  |   35 +++++++++++++++++++++++++++++++++--
>  2 files changed, 34 insertions(+), 3 deletions(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/