Date: Wed, 31 Jul 2013 12:25:34 -0700 (PDT)
Message-Id: <20130731.122534.774117327230299927.davem@redhat.com>
To: cmetcalf@tilera.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 09/12] tile: support TSO for IPv6 in tilegx network
 driver
From: David Miller <davem@redhat.com>
In-Reply-To: <799eca39dc7f85ba12e1d8c5b072f8b6740fda1c.1375283106.git.cmetcalf@tilera.com>
References: <cover.1374609948.git.cmetcalf@tilera.com>
	<cover.1375283104.git.cmetcalf@tilera.com>
	<799eca39dc7f85ba12e1d8c5b072f8b6740fda1c.1375283106.git.cmetcalf@tilera.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1284
Lines: 34

From: Chris Metcalf <cmetcalf@tilera.com>
Date: Wed, 31 Jul 2013 11:05:04 -0400

> @@ -1950,6 +1963,7 @@ static void tile_net_setup(struct net_device *dev)
>  	dev->features |= NETIF_F_HW_CSUM;
>  	dev->features |= NETIF_F_SG;
>  	dev->features |= NETIF_F_TSO;
> +	dev->features |= NETIF_F_TSO6;
>  	dev->mtu = 1500;

This driver is severely out of date wrt. how to properly advertise
device features, and you really need to fix this _before_ adding
support for new capabilities.

dev->hw_features specifies what the device is capable of, whereas
dev->features specifies what features are currently enabled.

Using these two values we determine what feature bits the user
can configure on and off using generic code which checks
dev->hw_features when the user makes a request.

You'll also want to have a look at netdev_ops->ndo_fix_features
and netdev_ops->ndo_set_features which allow a driver to handle
attempts to install illegal combinations of features.

You can look at other well maintained drivers to see how this
works.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/