Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760799Ab3GaVAo (ORCPT ); Wed, 31 Jul 2013 17:00:44 -0400 Received: from hydra.sisk.pl ([212.160.235.94]:49436 "EHLO hydra.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757339Ab3GaVAn (ORCPT ); Wed, 31 Jul 2013 17:00:43 -0400 From: "Rafael J. Wysocki" To: Stephen Warren Cc: Viresh Kumar , linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, arnd.bergmann@linaro.org, Stephen Warren Subject: Re: [PATCH 14/15] cpufreq: Tegra: initialize .owner field with THIS_MODULE Date: Wed, 31 Jul 2013 23:10:51 +0200 Message-ID: <7618517.DFSqTW80gq@vostro.rjw.lan> User-Agent: KMail/4.9.5 (Linux/3.10.0+; KDE/4.9.5; x86_64; ; ) In-Reply-To: <51F961C5.7070302@wwwdotorg.org> References: <7e832fd210488da0675b6c70fc9a3947eec7899d.1375279948.git.viresh.kumar@linaro.org> <51F961C5.7070302@wwwdotorg.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 31 On Wednesday, July 31, 2013 01:13:09 PM Stephen Warren wrote: > On 07/31/2013 08:19 AM, Viresh Kumar wrote: > > CPUFreq core does following at multiple places: > > module_{get|put}(cpufreq_driver->owner)). > > > > This is done to make sure module doesn't get unloaded if it is currently in use. > > This will work only if the .owner field of cpufreq driver is initialized with a > > valid pointer. > > > > This field wasn't initialized for this driver, lets initialize it with > > THIS_MODULE. > > Acked-by: Stephen Warren > > I assume this is all part of a series you'll take through the cpufreq tree. I'm going to apply this series eventually, but I'd like some ACKs to accumulate before doing that. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/