Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751712Ab3HAAEt (ORCPT ); Wed, 31 Jul 2013 20:04:49 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:35867 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863Ab3HAAEr (ORCPT ); Wed, 31 Jul 2013 20:04:47 -0400 Date: Wed, 31 Jul 2013 17:04:46 -0700 (PDT) Message-Id: <20130731.170446.1534643901297918794.davem@davemloft.net> To: joe@perches.com Cc: jonas.jensen@gmail.com, netdev@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, florian@openwrt.org Subject: Re: [PATCH v3] net: Add MOXA ART SoCs ethernet driver From: David Miller In-Reply-To: <1375296998.5729.8.camel@joe-AO722> References: <1374842890-20735-1-git-send-email-jonas.jensen@gmail.com> <1375280401-5564-1-git-send-email-jonas.jensen@gmail.com> <1375296998.5729.8.camel@joe-AO722> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.1 (shards.monkeyblade.net [0.0.0.0]); Wed, 31 Jul 2013 17:04:47 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 998 Lines: 29 From: Joe Perches Date: Wed, 31 Jul 2013 11:56:38 -0700 >> + if (ui & (RX_ERR | CRC_ERR | FTL | RUNT | RX_ODD_NB)) { >> + netdev_err(ndev, "packet error\n"); > > This is generally a bad idea as it can flood > the log. It's probably better to remove it. > If you really want logging, then at least use > net_ratelimit(). Generally, the stats are > enough. ... >> + priv->stats.rx_dropped++; >> + priv->stats.rx_errors++; > [] >> +static int moxart_mac_start_xmit(struct sk_buff *skb, struct net_device *ndev) > [] >> + if (txdesc->txdes0.ubit.tx_dma_own) { >> + netdev_err(ndev, "no TX space for packet\n"); >> + priv->stats.tx_dropped++; > > here too. Agreed, these should not be logged, the statistics are sufficient. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/