Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753898Ab3HADvs (ORCPT ); Wed, 31 Jul 2013 23:51:48 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:60314 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752963Ab3HADvr (ORCPT ); Wed, 31 Jul 2013 23:51:47 -0400 Message-ID: <51F9DB4F.3070805@felipetonello.com> Date: Wed, 31 Jul 2013 20:51:43 -0700 From: Felipe Ferreri Tonello User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Takashi Iwai CC: Mark Brown , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, David Henningsson , Wang Xingchao , Jaroslav Kysela Subject: Re: [PATCH 4/4] ALSA: oxygen: Updating jack implementation according new ALSA Jacks References: <1374863133-6745-1-git-send-email-eu@felipetonello.com> <1374863133-6745-5-git-send-email-eu@felipetonello.com> <20130726185609.GY9858@sirena.org.uk> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1872 Lines: 51 Hi Takashi, On 07/29/2013 05:10 AM, Takashi Iwai wrote: > At Fri, 26 Jul 2013 12:02:51 -0700, > Felipe Tonello wrote: >> >> Hi Mark, >> >> On Fri, Jul 26, 2013 at 11:56 AM, Mark Brown wrote: >>> On Fri, Jul 26, 2013 at 11:25:33AM -0700, Felipe F. Tonello wrote: >>>> From: "Felipe F. Tonello" >>>> >>>> ALSA standard jacks already are implemented using ALSA KControl. >>>> So there is no need implement that itself or to use snd_jack >>>> for input events only. >>> >>> Similar changlog comment as on the ASoC patch and... >> >> Ok. >> >>> >>>> snd_jack_new(chip->card, "Headphone", >>>> - SND_JACK_HEADPHONE, &data->hp_jack); >>>> + SND_JACK_HEADPHONE, 0, &data->hp_jack); >>>> xonar_ds_handle_hp_jack(chip); >>> >>> ...this really ought to be done as part of the commit that adds the >>> parameter since it breaks the build until this patch is applied. >> >> But that's why is a patch series. But as you say, are you suggesting >> me to propose this changes in one patch only? > > The basic rule of the patch series is: > - they are split in a logical manner > - each commit must not break the build > > The second rule is important especially for bisection and > backporting. You could have done in a different way (e.g. adding a > new function like snd_jack_new_with_index() instead of changing > snd_jack_new() itself). Which way is better, depends on the > implementation details. In this case I think this will not solve the issue. Because the my propose is to make the control creation standard for jacks. Felipe Tonello -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/