Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753915Ab3HAHbk (ORCPT ); Thu, 1 Aug 2013 03:31:40 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:54096 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753734Ab3HAHbf (ORCPT ); Thu, 1 Aug 2013 03:31:35 -0400 MIME-Version: 1.0 In-Reply-To: References: <1373972146-12133-1-git-send-email-sonic.adi@gmail.com> Date: Thu, 1 Aug 2013 15:31:34 +0800 Message-ID: Subject: Re: [PATCH 1/3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x. From: Sonic Zhang To: Linus Walleij Cc: Grant Likely , Steven Miao , LKML , adi-buildroot-devel@lists.sourceforge.net, Sonic Zhang Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 928 Lines: 28 Hi Linus, On Tue, Jul 30, 2013 at 12:47 AM, Linus Walleij wrote: > On Fri, Jul 26, 2013 at 6:57 AM, Sonic Zhang wrote: > >> Could you please comment on this patch set? It is based on your former comments. > > I'll get to it. I'm pretty choked right now and actually trying to have > some vacation at the same time. > > In the meantime, after glancing over and noting prolific use of the > unlikely() macro, please read the following articles: > http://lwn.net/Articles/70473/ > http://lwn.net/Articles/420019/ > These articles say the directives should be rarely used. Do you suggest to remove them from the patch? Regards, Sonic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/