Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753118Ab3HAHmc (ORCPT ); Thu, 1 Aug 2013 03:42:32 -0400 Received: from mail-ob0-f182.google.com ([209.85.214.182]:58606 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752553Ab3HAHm3 (ORCPT ); Thu, 1 Aug 2013 03:42:29 -0400 MIME-Version: 1.0 In-Reply-To: References: <1371146190-16786-1-git-send-email-zoran.markovic@linaro.org> Date: Thu, 1 Aug 2013 00:42:28 -0700 Message-ID: Subject: Re: [RFC PATCH] mmc: Enable wakeup_sources for mmc core From: Zoran Markovic To: Ulf Hansson Cc: Colin Cross , lkml , linux-mmc@vger.kernel.org, San Mehat , John Stultz , Chris Ball , Johan Rudholm , Jaehoon Chung , Konstantin Dorfman , Guennadi Liakhovetski , Tejun Heo , Andrew Morton Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2081 Lines: 54 Ulf, I got confirmation from Broadcom that all cell phone reference designs have card insert/removal configured as a wakeup IRQ. Unless our customers change that - which I doubt - this results in a considerable number of products implementing this feature. Please let me know how you wish to proceed. Cheers, Zoran On 26 June 2013 13:57, Ulf Hansson wrote: > On 24 June 2013 21:58, Zoran Markovic wrote: >>>> This patch is ported from the Android common tree, so you've probably >>>> been using it. >>> >>> We removed more or less all Android code in the mmc subsystem, since >>> it just didn't work. :-) >>> >>> The "deferred resume" was very useful though, so after some rework we >>> kept it and could then improve the system resume time significantly. >> >> For what it's worth, I fixed one bug I noticed in the Android kernel: >> if a system has a non-removable MMC device, a suspend/resume cycle on >> this device would hold a wake lock forever. This was a visible issue >> on the panda board I am using. >> >> If there are doubts on whether or not the system should stay awake >> during a MMC mount, we have the option to make the calls to >> wakeup_source_register/unregister configurable. Skipping these calls >> would leave the .ws field NULL, in which case >> __pm_stay_awake/__pm_relax/__pm_wakeup_event would do nothing. > > Even if we make this feature configurable, I can't see any host driver > that would benefit from it as of today. The reason is simply that host > drivers do not configure it's card detect irq as a wakeup irq. Myself > is also having quite hard to see the benefit of doing that, but I > don't know all the use cases. > > Let's see if we can get someone else to provide input... > >> >> Thoughts? >> >> - Zoran > > > Kind regards > Ulf Hansson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/