Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754410Ab3HAJy1 (ORCPT ); Thu, 1 Aug 2013 05:54:27 -0400 Received: from service87.mimecast.com ([91.220.42.44]:47574 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754291Ab3HAJyW convert rfc822-to-8bit (ORCPT ); Thu, 1 Aug 2013 05:54:22 -0400 Message-ID: <51FA3064.9080502@arm.com> Date: Thu, 01 Aug 2013 10:54:44 +0100 From: Sudeep KarkadaNagesha User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 MIME-Version: 1.0 To: Sudeep KarkadaNagesha , Gregory Clement , Andrew Lunn , Jason Cooper CC: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , Russell King , Shawn Guo , Greg Kroah-Hartman , Viresh Kumar , "Rafael J. Wysocki" , "grant.likely@linaro.org" , "rob.herring@calxeda.com" , Lorenzo Pieralisi , Olof Johansson , Arnd Bergmann Subject: Re: [PATCH v3 05/16] ARM: mvebu: remove device tree parsing for cpu nodes References: <1374069984-20567-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1374492747-13879-1-git-send-email-Sudeep.KarkadaNagesha@arm.com> <1374492747-13879-6-git-send-email-Sudeep.KarkadaNagesha@arm.com> In-Reply-To: <1374492747-13879-6-git-send-email-Sudeep.KarkadaNagesha@arm.com> X-OriginalArrivalTime: 01 Aug 2013 09:54:17.0817 (UTC) FILETIME=[16761490:01CE8E9D] X-MC-Unique: 113080110542000501 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3090 Lines: 115 On 22/07/13 12:32, Sudeep KarkadaNagesha wrote: > From: Sudeep KarkadaNagesha > > Currently set_secondary_cpus_clock assume the CPU logical ordering > and the MPDIR in DT are same, which is incorrect. > > Since the CPU device nodes can be retrieved in the logical ordering > using the DT helper, we can remove the devices tree parsing. > > This patch removes DT parsing by making use of of_get_cpu_node. > > Cc: Gregory Clement > Cc: Andrew Lunn > Cc: Jason Cooper > Signed-off-by: Sudeep KarkadaNagesha Hi Gregory/Andrew/Jason, Does this change look fine for mvebu? If yes, can I have your ACKs ? Regards, Sudeep > --- > arch/arm/mach-mvebu/platsmp.c | 52 ++++++++++++++++++++----------------------- > 1 file changed, 24 insertions(+), 28 deletions(-) > > diff --git a/arch/arm/mach-mvebu/platsmp.c b/arch/arm/mach-mvebu/platsmp.c > index ce81d30..001dd42 100644 > --- a/arch/arm/mach-mvebu/platsmp.c > +++ b/arch/arm/mach-mvebu/platsmp.c > @@ -23,51 +23,47 @@ > #include > #include > #include > +#include > #include > #include "common.h" > #include "armada-370-xp.h" > #include "pmsu.h" > #include "coherency.h" > > +static struct clk *__init get_cpu_clk(int cpu) > +{ > + struct clk *cpu_clk; > + struct device_node *np = of_get_cpu_node(cpu); > + > + if (WARN(!np, "missing cpu node\n")) > + return NULL; > + cpu_clk = of_clk_get(np, 0); > + if (WARN_ON(IS_ERR(cpu_clk))) > + return NULL; > + return cpu_clk; > +} > + > void __init set_secondary_cpus_clock(void) > { > - int thiscpu; > + int thiscpu, cpu; > unsigned long rate; > - struct clk *cpu_clk = NULL; > - struct device_node *np = NULL; > + struct clk *cpu_clk; > > thiscpu = smp_processor_id(); > - for_each_node_by_type(np, "cpu") { > - int err; > - int cpu; > - > - err = of_property_read_u32(np, "reg", &cpu); > - if (WARN_ON(err)) > - return; > - > - if (cpu == thiscpu) { > - cpu_clk = of_clk_get(np, 0); > - break; > - } > - } > - if (WARN_ON(IS_ERR(cpu_clk))) > + cpu_clk = get_cpu_clk(thiscpu); > + if (!cpu_clk) > return; > clk_prepare_enable(cpu_clk); > rate = clk_get_rate(cpu_clk); > > /* set all the other CPU clk to the same rate than the boot CPU */ > - for_each_node_by_type(np, "cpu") { > - int err; > - int cpu; > - > - err = of_property_read_u32(np, "reg", &cpu); > - if (WARN_ON(err)) > + for_each_possible_cpu(cpu) { > + if (cpu == thiscpu) > + continue; > + cpu_clk = get_cpu_clk(cpu); > + if (!cpu_clk) > return; > - > - if (cpu != thiscpu) { > - cpu_clk = of_clk_get(np, 0); > - clk_set_rate(cpu_clk, rate); > - } > + clk_set_rate(cpu_clk, rate); > } > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/