Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755149Ab3HAMVQ (ORCPT ); Thu, 1 Aug 2013 08:21:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4162 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753884Ab3HAMVP (ORCPT ); Thu, 1 Aug 2013 08:21:15 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1374721150.1924.26.camel@joe-AO722> References: <1374721150.1924.26.camel@joe-AO722> <1374602291.3387.17.camel@joe-AO722> <1374716480.1924.18.camel@joe-AO722> <20130725014732.GA10036@order.stressinduktion.org> To: Joe Perches Cc: dhowells@redhat.com, Andrew Morton , Andy Whitcroft , Hannes Frederic Sowa , Cong Wang , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] checkpatch: Warn when using extern with function prototypes in .h files Date: Thu, 01 Aug 2013 13:21:04 +0100 Message-ID: <25105.1375359664@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 823 Lines: 25 Joe Perches wrote: > Using the extern keyword on function prototypes is superfluous > visual noise so suggest removing it. > > Using extern can cause unnecessary line wrapping at 80 columns > and unnecessarily long multi-line function prototypes. > > Suggested-by: Hannes Frederic Sowa > Signed-off-by: Joe Perches Nak. The "extern" makes it much easier to pick out at a glance. Please standardise on there _being_ externs if you must do this. It's gratuitous change anyway and not worth the churn. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/