Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755761Ab3HANme (ORCPT ); Thu, 1 Aug 2013 09:42:34 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:47285 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755584Ab3HANmb (ORCPT ); Thu, 1 Aug 2013 09:42:31 -0400 Date: Thu, 1 Aug 2013 15:42:28 +0200 From: Frederic Weisbecker To: Jiri Olsa Cc: Peter Zijlstra , LKML , Namhyung Kim , Ingo Molnar , Arnaldo Carvalho de Melo , Stephane Eranian Subject: Re: [PATCH 2/8] perf: Sanitize get_callchain_buffer() Message-ID: <20130801134226.GC431@somewhere> References: <1374539466-4799-1-git-send-email-fweisbec@gmail.com> <1374539466-4799-3-git-send-email-fweisbec@gmail.com> <20130801132934.GG1032@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130801132934.GG1032@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1367 Lines: 44 On Thu, Aug 01, 2013 at 03:29:34PM +0200, Jiri Olsa wrote: > On Tue, Jul 23, 2013 at 02:31:00AM +0200, Frederic Weisbecker wrote: > SNIP > > > if (event->attach_state & PERF_ATTACH_TASK) > > static_key_slow_inc(&perf_sched_events.key); > > if (event->attr.mmap || event->attr.mmap_data) > > @@ -6572,16 +6570,19 @@ done: > > atomic_inc(&per_cpu(perf_branch_stack_events, > > event->cpu)); > > } > > - if (event->attr.sample_type & PERF_SAMPLE_CALLCHAIN) { > > - err = get_callchain_buffers(); > > - if (err) { > > - free_event(event); > > - return ERR_PTR(err); > > - } > > - } > > } > > > > return event; > > + > > +err_pmu: > > + if (event->destroy) > > + event->destroy(event); > > +err_ns: > > + if (event->ns) > > + put_pid_ns(event->ns); > > + kfree(event); > > + > > + return ERR_PTR(err); > > could we call __free_filter(event) here? Hmm, the filters are installed from ioctl time so there shouldn't be any yet. But there should be an exception with inherited events. I fail to find where the filter is inherited though. Do we actually inherit those? thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/