Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755866Ab3HARhL (ORCPT ); Thu, 1 Aug 2013 13:37:11 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:38479 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752245Ab3HARhF (ORCPT ); Thu, 1 Aug 2013 13:37:05 -0400 MIME-Version: 1.0 In-Reply-To: <20130731184724.GA30896@srcf.ucam.org> References: <3453253.oZLO1ChPbL@vostro.rjw.lan> <37178266.QXgbv9rq0i@vostro.rjw.lan> <20130731051421.GA15766@srcf.ucam.org> <20130731140010.GA24560@srcf.ucam.org> <20130731175232.GA29987@srcf.ucam.org> <20130731184724.GA30896@srcf.ucam.org> Date: Thu, 1 Aug 2013 12:37:04 -0500 Message-ID: Subject: Re: [REGRESSION/PATCH] acpi: blacklist win8 OSI for ASUS Zenbok Prime UX31A From: Felipe Contreras To: Matthew Garrett Cc: "Rafael J. Wysocki" , Aaron Lu , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Len Brown , Linus Torvalds Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 36 On Wed, Jul 31, 2013 at 1:47 PM, Matthew Garrett wrote: > On Wed, Jul 31, 2013 at 01:07:57PM -0500, Felipe Contreras wrote: >> If we can make the software behave consistently for 99% of the >> machines out there instead of only 90%, that's better. > > If we can't make an interface 100% consistent, we shouldn't pretend that > the interface is 100% consistent. We can't, and so we don't. Setting a > backlight value of 0 may turn the screen off, and userspace needs to > deal with that. This is insanity; we can never guarantee 100% of anything. Better is better. And 99% is better than 90% % git grep quirks | wc -l 1585 Moreover, Linux already does quirks, and when there are quirks it means there's no 100% guarantee of the thing working as it should; hence the need for quirks, which is never complete, never 100%. Anyway, screw the users, right? All you care about is that the code looks good to you. If we care about the users, we would provide a consistent interface, where 0 means the same thing on all the backlight drivers. If all we can do is provide this consistency 99% of the time through quirks, that is the way to go. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/