Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753455Ab3HBBDF (ORCPT ); Thu, 1 Aug 2013 21:03:05 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:34010 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753297Ab3HBBDC (ORCPT ); Thu, 1 Aug 2013 21:03:02 -0400 Date: Fri, 2 Aug 2013 03:02:59 +0200 From: Pavel Machek To: Bjorn Helgaas Cc: Greg KH , kernel list , Joe Lawrence , Myron Stowe , Jeff Kirsher , Jesse Brandeburg , Bruce Allan , Carolyn Wyborny , Don Skidmore , Greg Rose , Peter P Waskiewicz Jr , Alex Duyck , John Ronciak , Tushar Dave , "e1000-devel@lists.sourceforge.net" Subject: Re: /sys/module/pcie_aspm/parameters/policy not writable? Message-ID: <20130802010259.GA4779@amd.pavel.ucw.cz> References: <20130709094906.GA3870@amd.pavel.ucw.cz> <20130709101039.GA4479@amd.pavel.ucw.cz> <20130710132950.GA3684@amd.pavel.ucw.cz> <20130712111121.GB3515@amd.pavel.ucw.cz> <20130801200008.GA5495@amd.pavel.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2267 Lines: 50 Hi! > >> > But since the problem also occurs with Windows, it's pretty likely > >> > that there's a BIOS update to fix it. I notice on the X60 support > >> > page that there are several versions newer than what you're running. > >> > >> Do you have any interest in trying a newer BIOS to see if it's fixed > >> there? If not, I understand; BIOS updates are a hassle at best. > >> You're running BIOS 2.14, and it looks like the current BIOS for an > >> X60 1709 7HU is 2.19 (from http://support.lenovo.com). > > > > I'm lost at the lenovo pages :-(. And frankly I'd prefer not to touch > > the BIOS. > > I tried to provide a complete link, but the web site isn't amenable to > that. I found it by selecting the "Drivers & Software" section, > entering "X60" as the machine type, selecting "ThinkPad X60 (1709)" > and going to the "BIOS" section. I was surprised how easy it was :) Ok, got it, the web pages are horible. > >> Carolyn's patch will likely work, at least most of the time, but I > >> think there's a small possibility that it could cause a conflict > >> between the BIOS and the OS over ASPM control, so I'm not 100% in > >> support of that approach. A conflict may not happen on your > >> machine, > > > > Can we base it on DMI whitelist? > > I don't think we can know a priori whether a machine (even your > machine) is susceptible to a conflict. But if Carolyn forcibly > disables it in the driver, she can structure that with a whitelist or > whatever she thinks is best. Well, there's only one way to find out: try it. I was running with the "enable ASPM so we can disable it" one-liner for a while, and seen no ill effects. Anyway, if you don't hear from me again, it means that I have a brick (and not a notebook) and am desperately trying to get replacement X60. Will try to flash it in few minutes. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/